linux-kernel - Re: [Resend: PATCH] PCI: designware: fix the boot noise for missing *config* reg space

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <81A7634D-6946-45CB-9DFF-4FD728632D14@gmail.com>
Date:	Fri, 31 Jul 2015 17:18:49 +0900
From:	Jingoo Han <jingoohan1@...il.com>
To:	Murali Karicheri <m-karicheri2@...com>
Cc:	"<pratyush.anand@...il.com>" <pratyush.anand@...il.com>,
	"<bhelgaas@...gle.com>" <bhelgaas@...gle.com>,
	"<linux-pci@...r.kernel.org>" <linux-pci@...r.kernel.org>,
	"<linux-kernel@...r.kernel.org>" <linux-kernel@...r.kernel.org>,
	jingoohan1@...il.com
Subject: Re: [Resend: PATCH] PCI: designware: fix the boot noise for missing *config* reg space

On 2015. 7. 22., at AM 6:54, Murali Karicheri <m-karicheri2@...com> wrote:
> 
> Currently on Keystone SoCs, boot up log shows an unnecessary boot
> noise as follows:-
> 
> [    0.365823] keystone-pcie 21021000.pcie: missing *config* reg space
> 
> Keystone uses older version of designware h/w that doesn't have ATU
> support. So va_cfg0_base and va_cfg1_base are already set up in
> ks_dw_pcie_host_init() before calling dw_pcie_host_init() and
> they point to the remote config space address va (both same for Keystone).
> So add a check to avoid this boot noise on Keystone.
> 
> Signed-off-by: Murali Karicheri <m-karicheri2@...com>

Acked-by: Jingoo Han <jingoohan1@...il.com>

Best regards,
Jingoo Han

> ---
> - Resend with "PCI: designware" prefix in subject
> drivers/pci/host/pcie-designware.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/pci/host/pcie-designware.c b/drivers/pci/host/pcie-designware.c
> index 69486be..b48b8a2 100644
> --- a/drivers/pci/host/pcie-designware.c
> +++ b/drivers/pci/host/pcie-designware.c
> @@ -388,7 +388,7 @@ int dw_pcie_host_init(struct pcie_port *pp)
>        addrp = of_get_address(np, index, NULL, NULL);
>        pp->cfg0_mod_base = of_read_number(addrp, ns);
>        pp->cfg1_mod_base = pp->cfg0_mod_base + pp->cfg0_size;
> -    } else {
> +    } else if (!pp->va_cfg0_base) {
>        dev_err(pp->dev, "missing *config* reg space\n");
>    }
> 
> -- 
> 1.9.1
> 
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/