linux-kernel - Re: [PATCH 5/8] x86/vm86: Add a separate config option for hardware IRQ handling

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20150731085750.GA8289@gmail.com>
Date:	Fri, 31 Jul 2015 10:57:50 +0200
From:	Ingo Molnar <mingo@...nel.org>
To:	Brian Gerst <brgerst@...il.com>
Cc:	x86@...nel.org, linux-kernel@...r.kernel.org,
	"H. Peter Anvin" <hpa@...or.com>,
	Denys Vlasenko <dvlasenk@...hat.com>,
	Andy Lutomirski <luto@...capital.net>,
	Linus Torvalds <torvalds@...ux-foundation.org>
Subject: Re: [PATCH 5/8] x86/vm86: Add a separate config option for hardware
 IRQ handling


* Brian Gerst <brgerst@...il.com> wrote:

> Allow disabling hardware interrupt support for vm86.
> 
> Signed-off-by: Brian Gerst <brgerst@...il.com>
> ---
>  arch/x86/Kconfig                   |  8 ++++++++
>  arch/x86/include/asm/irq_vectors.h | 10 ----------
>  arch/x86/include/asm/vm86.h        | 20 ++++++++++++++++++--
>  arch/x86/kernel/vm86_32.c          | 12 ++++++++++--
>  4 files changed, 36 insertions(+), 14 deletions(-)
> 
> diff --git a/arch/x86/Kconfig b/arch/x86/Kconfig
> index cbd2d62..7c7ec31 100644
> --- a/arch/x86/Kconfig
> +++ b/arch/x86/Kconfig
> @@ -1067,6 +1067,14 @@ config VM86
>         bool
>         default X86_LEGACY_VM86
>  
> +config VM86_INTERRUPTS
> +	bool "Enable VM86 interrupt support"
> +	default y
> +	depends on VM86
> +	---help---
> +	  This option allows VM86 programs to request interrupts for
> +	  real mode hardware drivers.

So I'm wondering what the justification for this is. People can disable vm86 
already via CONFIG_X86_LEGACY_VM86. The extra config just uglifies the code 
unnecessarily.

Thanks,

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/