linux-kernel - Re: [PATCH 4/8] x86/vm86: Use the normal pt

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20150731091226.GA21116@gmail.com>
Date:	Fri, 31 Jul 2015 11:12:26 +0200
From:	Ingo Molnar <mingo@...nel.org>
To:	Brian Gerst <brgerst@...il.com>
Cc:	x86@...nel.org, linux-kernel@...r.kernel.org,
	"H. Peter Anvin" <hpa@...or.com>,
	Denys Vlasenko <dvlasenk@...hat.com>,
	Andy Lutomirski <luto@...capital.net>,
	Linus Torvalds <torvalds@...ux-foundation.org>
Subject: Re: [PATCH 4/8] x86/vm86: Use the normal pt_regs area for vm86


* Brian Gerst <brgerst@...il.com> wrote:

> --- a/arch/x86/include/asm/vm86.h
> +++ b/arch/x86/include/asm/vm86.h

> +static inline void save_v86_state(struct kernel_vm86_regs *, int) { }
> +

So this is not a valid inline function and the patches were clearly not built with 
!VM86 such as 64-bit defconfig:

 In file included from arch/x86/kernel/signal.c:34:0:
 ./arch/x86/include/asm/vm86.h: In function ‘save_v86_state’:
 ./arch/x86/include/asm/vm86.h:70:42: error: parameter name omitted
  static inline void save_v86_state(struct kernel_vm86_regs *, int) { }
 ./arch/x86/include/asm/vm86.h:70:42: error: parameter name omitted

I fixed this up.

Thanks,

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/