linux-kernel - Re: [PATCH] regmap: remove redundant $(CONFIG

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20150801105914.GR20873@sirena.org.uk>
Date:	Sat, 1 Aug 2015 11:59:14 +0100
From:	Mark Brown <broonie@...nel.org>
To:	Masahiro Yamada <yamada.masahiro@...ionext.com>
Cc:	linux-kernel@...r.kernel.org,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>
Subject: Re: [PATCH] regmap: remove redundant $(CONFIG_REGMAP) in Makefile

On Sat, Aug 01, 2015 at 04:42:27AM +0900, Masahiro Yamada wrote:
> Kbuild descends into drivers/base/regmap/ only when CONFIG_REGMAP
> is enabled. (see drivers/base/Makefile)
> 
> $(CONFIG_REGMAP) in drivers/base/regmap/Makefile always evaluates
> to 'y'.

> -obj-$(CONFIG_REGMAP) += regmap.o regcache.o
> -obj-$(CONFIG_REGMAP) += regcache-rbtree.o regcache-lzo.o regcache-flat.o
> +obj-y += regmap.o regcache.o
> +obj-y += regcache-rbtree.o regcache-lzo.o regcache-flat.o
>  obj-$(CONFIG_DEBUG_FS) += regmap-debugfs.o
>  obj-$(CONFIG_REGMAP_AC97) += regmap-ac97.o
>  obj-$(CONFIG_REGMAP_I2C) += regmap-i2c.o

OTOH it does make the Makefile look a bit neater to have everything
selected by config option...  is there a practical cost here?

Download attachment "signature.asc" of type "application/pgp-signature" (474 bytes)