linux-kernel - Re: [PATCH] regmap: remove redundant $(CONFIG

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAK7LNAS=4fiVSQdQfR=ufiHswF9hZ2pPdnXMmX7bA0-KeMfZJg@mail.gmail.com>
Date:	Sat, 1 Aug 2015 21:30:22 +0900
From:	Masahiro Yamada <yamada.masahiro@...ionext.com>
To:	Mark Brown <broonie@...nel.org>
Cc:	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>
Subject: Re: [PATCH] regmap: remove redundant $(CONFIG_REGMAP) in Makefile

Hi Mark,


2015-08-01 19:59 GMT+09:00 Mark Brown <broonie@...nel.org>:
> On Sat, Aug 01, 2015 at 04:42:27AM +0900, Masahiro Yamada wrote:
>> Kbuild descends into drivers/base/regmap/ only when CONFIG_REGMAP
>> is enabled. (see drivers/base/Makefile)
>>
>> $(CONFIG_REGMAP) in drivers/base/regmap/Makefile always evaluates
>> to 'y'.
>
>> -obj-$(CONFIG_REGMAP) += regmap.o regcache.o
>> -obj-$(CONFIG_REGMAP) += regcache-rbtree.o regcache-lzo.o regcache-flat.o
>> +obj-y += regmap.o regcache.o
>> +obj-y += regcache-rbtree.o regcache-lzo.o regcache-flat.o
>>  obj-$(CONFIG_DEBUG_FS) += regmap-debugfs.o
>>  obj-$(CONFIG_REGMAP_AC97) += regmap-ac97.o
>>  obj-$(CONFIG_REGMAP_I2C) += regmap-i2c.o
>
> OTOH it does make the Makefile look a bit neater to have everything
> selected by config option...  is there a practical cost here?


Almost no cost.

We can save expanding $(CONFIG_REGMAP),
but it is practically unnoticeable.

Please feel free to ignore this patch if you do not like it.



-- 
Best Regards
Masahiro Yamada
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/