linux-kernel - Re: [tip:x86/asm] x86/vm86: Clean up vm86.h includes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20150801082239.GA12202@gmail.com>
Date:	Sat, 1 Aug 2015 10:22:40 +0200
From:	Ingo Molnar <mingo@...nel.org>
To:	Brian Gerst <brgerst@...il.com>
Cc:	Borislav Petkov <bp@...en8.de>,
	Andy Lutomirski <luto@...capital.net>,
	"H. Peter Anvin" <hpa@...or.com>,
	Linus Torvalds <torvalds@...ux-foundation.org>,
	Thomas Gleixner <tglx@...utronix.de>,
	Peter Zijlstra <peterz@...radead.org>,
	Denys Vlasenko <dvlasenk@...hat.com>,
	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
	linux-tip-commits@...r.kernel.org
Subject: Re: [tip:x86/asm] x86/vm86: Clean up vm86.h includes


* Brian Gerst <brgerst@...il.com> wrote:

> On Fri, Jul 31, 2015 at 10:04 AM, tip-bot for Brian Gerst
> <tipbot@...or.com> wrote:
> > Commit-ID:  ba3e127ec105e790eeec4034d9769e018e4a1b54
> > Gitweb:     http://git.kernel.org/tip/ba3e127ec105e790eeec4034d9769e018e4a1b54
> > Author:     Brian Gerst <brgerst@...il.com>
> > AuthorDate: Wed, 29 Jul 2015 01:41:21 -0400
> > Committer:  Ingo Molnar <mingo@...nel.org>
> > CommitDate: Fri, 31 Jul 2015 13:31:10 +0200
> >
> > x86/vm86: Clean up vm86.h includes
> >
> > vm86.h was being implicitly included in alot of places via
> > processor.h, which in turn got it from math_emu.h.  Break that
> > chain and explicitly include vm86.h in all files that need it.
> > Also remove unused vm86 field from math_emu_info.
> >
> > Signed-off-by: Brian Gerst <brgerst@...il.com>
> > Cc: Andy Lutomirski <luto@...capital.net>
> > Cc: Borislav Petkov <bp@...en8.de>
> > Cc: Denys Vlasenko <dvlasenk@...hat.com>
> > Cc: H. Peter Anvin <hpa@...or.com>
> > Cc: Linus Torvalds <torvalds@...ux-foundation.org>
> > Cc: Peter Zijlstra <peterz@...radead.org>
> > Cc: Thomas Gleixner <tglx@...utronix.de>
> > Link: http://lkml.kernel.org/r/1438148483-11932-7-git-send-email-brgerst@gmail.com
> > [ Fixed build failure. ]
> > Signed-off-by: Ingo Molnar <mingo@...nel.org>
> 
> 
> > diff --git a/drivers/scsi/dpt_i2o.c b/drivers/scsi/dpt_i2o.c
> > index f35ed53..d4cda5e 100644
> > --- a/drivers/scsi/dpt_i2o.c
> > +++ b/drivers/scsi/dpt_i2o.c
> > @@ -1924,6 +1924,9 @@ static void adpt_alpha_info(sysInfo_S* si)
> >  #endif
> >
> >  #if defined __i386__
> > +
> > +#include <uapi/asm/vm86.h>
> > +
> >  static void adpt_i386_info(sysInfo_S* si)
> >  {
> >         // This is all the info we need for now
> 
> It would have been better to just remove the the CPU_* defines from
> this driver.  boot_cpu_data.x86 is simply the family ID from CPUID,
> and nowhere else uses defines like this.

Please send a followup patch for that.

Thanks,

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/