linux-kernel - Re: [PATCH V2] staging: android: lowmemorykiller: imporve lmk to avoid deadlock issue

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20150803071604.GT5096@mwanda>
Date:	Mon, 3 Aug 2015 10:16:04 +0300
From:	Dan Carpenter <dan.carpenter@...cle.com>
To:	"Wang, Biao" <biao.wang@...el.com>
Cc:	"gregkh@...uxfoundation.org" <gregkh@...uxfoundation.org>,
	"arve@...roid.com" <arve@...roid.com>,
	"riandrews@...roid.com" <riandrews@...roid.com>,
	"devel@...verdev.osuosl.org" <devel@...verdev.osuosl.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"Zhang, Di" <di.zhang@...el.com>, "Li, Fei" <fei.li@...el.com>,
	"joe@...ches.com" <joe@...ches.com>
Subject: Re: [PATCH V2]  staging: android: lowmemorykiller: imporve lmk to
 avoid deadlock issue

On Mon, Aug 03, 2015 at 09:15:56AM +0300, Dan Carpenter wrote:
> > Reviewed-by: Dan Carpenter <dan.carpenter@...cle.com>
> 
> I don't really feel comfortable saying I reviewed this code.  I just
> commented on a few process issues.  I don't know the subsystem well
> enough to give it a seal of approval.
> 

Biao was asking off list, how to fix this.  I guess just leave it.  I
more care about going forward that we don't start doing this all the
time.

I recently added a reviewed-by tag for someone.  He told me off list
that the patch "looks OK".  He was the subsystem expert and we were
patching his code so it was his responsibility to review the fix.  If
the patch breaks everyone's system then he's absolutely the guy that I
want people to blame.  :)

regards,
dan carpenter

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/