lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Mon, 3 Aug 2015 10:56:18 +0200 From: Linus Walleij <linus.walleij@...aro.org> To: Grygorii Strashko <grygorii.strashko@...com> Cc: Rabin Vincent <rabin@....in>, Alexandre Courbot <gnurou@...il.com>, "linux-gpio@...r.kernel.org" <linux-gpio@...r.kernel.org>, "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org> Subject: Re: [PATCH 1/2] gpio: don't override irq_*_resources() callbacks On Fri, Jul 31, 2015 at 4:54 PM, Grygorii Strashko <grygorii.strashko@...com> wrote: > On 07/31/2015 03:48 PM, Rabin Vincent wrote: >> + if (!irqchip->irq_request_resources && >> + !irqchip->irq_release_resources) { >> + irqchip->irq_request_resources = gpiochip_irq_reqres; >> + irqchip->irq_release_resources = gpiochip_irq_relres; >> + } > > I think, it will be better to handle req/rel cases separately. No, I think that could be dangerous. The semantics of the both functions are intertwined, if we change something in the core we may break drivers. It would be better with a mechanism saying "also do this on irq_request/release resource" so a secondary vtable for these two. Where the latter would be optional per-callback. That way the ETRAXFS does not need to reimplement irq locking. I'll see what I can come up with. Yours, Linus Walleij -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists