linux-kernel - Re: [PATCH 4/4] drivers:pci:hv: New paravirtual PCI front-end for Hyper-V VMs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20150803093534.GV5180@mwanda>
Date:	Mon, 3 Aug 2015 12:52:50 +0300
From:	Dan Carpenter <dan.carpenter@...cle.com>
To:	Paul Bolle <pebolle@...cali.nl>
Cc:	jakeo@...rosoft.com, olaf@...fle.de, gregkh@...uxfoundation.org,
	linux-kernel@...r.kernel.org, bhelgaas@...gle.com,
	linux-pci@...r.kernel.org, apw@...onical.com,
	devel@...uxdriverproject.org, tglx@...utronix.de
Subject: Re: [PATCH 4/4] drivers:pci:hv: New paravirtual PCI front-end for
 Hyper-V VMs

On Mon, Aug 03, 2015 at 11:18:12AM +0200, Paul Bolle wrote:
> On zo, 2015-08-02 at 00:54 +0000, jakeo@...rosoft.com wrote:
> > --- /dev/null
> > +++ b/drivers/pci/host/hv_pcifront.c
> 
> > +static void exit_hv_pci_drv(void)
> > +{
> > +	vmbus_driver_unregister(&hv_pci_drv);
> > +}
> > +
> > +static int __init init_hv_pci_drv(void)
> > +{
> > +	int ret;
> > +
> > +	/* Register this driver with VMBus. */
> > +	ret = vmbus_driver_register(&hv_pci_drv);
> > +
> > +	if (ret < 0)
> > +		exit_hv_pci_drv();
> > +
> > +	return ret;
> > +}
> 
> Wouldn't just
>     static int __init init_hv_pci_drv(void)
>     {
>     	return vmbus_driver_register(&hv_pci_drv);
>     }
> 
> suffice here?

You're right, of course.  The error handling is buggy.

regards,
dan carpenter

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/