linux-kernel - Re: [PATCH 4/4] drivers:pci:hv: New paravirtual PCI front-end for Hyper-V VMs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 03 Aug 2015 11:18:12 +0200
From:	Paul Bolle <pebolle@...cali.nl>
To:	jakeo@...rosoft.com
Cc:	gregkh@...uxfoundation.org, kys@...rosoft.com,
	linux-kernel@...r.kernel.org, devel@...uxdriverproject.org,
	olaf@...fle.de, apw@...onical.com, vkuznets@...hat.com,
	linux-pci@...r.kernel.org, bhelgaas@...gle.com, tglx@...utronix.de
Subject: Re: [PATCH 4/4] drivers:pci:hv: New paravirtual PCI front-end for
 Hyper-V VMs

On zo, 2015-08-02 at 00:54 +0000, jakeo@...rosoft.com wrote:
> --- /dev/null
> +++ b/drivers/pci/host/hv_pcifront.c

> +static void exit_hv_pci_drv(void)
> +{
> +	vmbus_driver_unregister(&hv_pci_drv);
> +}
> +
> +static int __init init_hv_pci_drv(void)
> +{
> +	int ret;
> +
> +	/* Register this driver with VMBus. */
> +	ret = vmbus_driver_register(&hv_pci_drv);
> +
> +	if (ret < 0)
> +		exit_hv_pci_drv();
> +
> +	return ret;
> +}

Wouldn't just
    static int __init init_hv_pci_drv(void)
    {
    	return vmbus_driver_register(&hv_pci_drv);
    }

suffice here? That would also allow to mark exit_hv_pci_drv() with
__exit.

> +module_init(init_hv_pci_drv);
> +module_exit(exit_hv_pci_drv);

Thanks,


Paul Bolle
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/