linux-kernel - Re: [PATCHv9 25/36] mm, thp: remove infrastructure for handling splitting PMDs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <55BF5340.4080008@redhat.com>
Date:	Mon, 03 Aug 2015 13:40:48 +0200
From:	Jerome Marchand <jmarchan@...hat.com>
To:	"Kirill A. Shutemov" <kirill@...temov.name>
CC:	"Kirill A. Shutemov" <kirill.shutemov@...ux.intel.com>,
	Andrew Morton <akpm@...ux-foundation.org>,
	Andrea Arcangeli <aarcange@...hat.com>,
	Hugh Dickins <hughd@...gle.com>,
	Dave Hansen <dave.hansen@...el.com>,
	Mel Gorman <mgorman@...e.de>, Rik van Riel <riel@...hat.com>,
	Vlastimil Babka <vbabka@...e.cz>,
	Christoph Lameter <cl@...two.org>,
	Naoya Horiguchi <n-horiguchi@...jp.nec.com>,
	Steve Capper <steve.capper@...aro.org>,
	"Aneesh Kumar K.V" <aneesh.kumar@...ux.vnet.ibm.com>,
	Johannes Weiner <hannes@...xchg.org>,
	Michal Hocko <mhocko@...e.cz>,
	Sasha Levin <sasha.levin@...cle.com>,
	linux-kernel@...r.kernel.org, linux-mm@...ck.org
Subject: Re: [PATCHv9 25/36] mm, thp: remove infrastructure for handling splitting
 PMDs

On 08/03/2015 12:41 PM, Kirill A. Shutemov wrote:
> On Fri, Jul 31, 2015 at 05:01:06PM +0200, Jerome Marchand wrote:
>> On 07/20/2015 04:20 PM, Kirill A. Shutemov wrote:
>>> @@ -1616,23 +1605,14 @@ int change_huge_pmd(struct vm_area_struct *vma, pmd_t *pmd,
>>>   * Note that if it returns 1, this routine returns without unlocking page
>>>   * table locks. So callers must unlock them.
>>>   */
>>
>> The comment above should be updated.
> 
> Like this?

Yes. Thanks.

> 
> diff --git a/mm/huge_memory.c b/mm/huge_memory.c
> index d32277463932..78a6c7cdf8f7 100644
> --- a/mm/huge_memory.c
> +++ b/mm/huge_memory.c
> @@ -1627,11 +1627,10 @@ int change_huge_pmd(struct vm_area_struct *vma, pmd_t *pmd,
>  }
>  
>  /*
> - * Returns 1 if a given pmd maps a stable (not under splitting) thp.
> - * Returns -1 if it maps a thp under splitting. Returns 0 otherwise.
> + * Returns true if a given pmd maps a thp, false otherwise.
>   *
> - * Note that if it returns 1, this routine returns without unlocking page
> - * table locks. So callers must unlock them.
> + * Note that if it returns true, this routine returns without unlocking page
> + * table lock. So callers must unlock it.
>   */
>  bool __pmd_trans_huge_lock(pmd_t *pmd, struct vm_area_struct *vma,
>  		spinlock_t **ptl)
> 



Download attachment "signature.asc" of type "application/pgp-signature" (474 bytes)