linux-kernel - Re: [PATCH 00/15] trivial: Drop unlikely before IS_ERR(_OR

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20150803173820.5a6111ea@gandalf.local.home>
Date:	Mon, 3 Aug 2015 17:38:20 -0400
From:	Steven Rostedt <rostedt@...dmis.org>
To:	"Kirill A. Shutemov" <kirill@...temov.name>
Cc:	Vlastimil Babka <vbabka@...e.cz>,
	Viresh Kumar <viresh.kumar@...aro.org>,
	akpm@...ux-foundation.org, linaro-kernel@...ts.linaro.org,
	linux-kernel@...r.kernel.org,
	Hans Ulli Kroll <ulli.kroll@...glemail.com>,
	Alexandre Belloni <alexandre.belloni@...e-electrons.com>,
	Oleg Drokin <oleg.drokin@...el.com>,
	Andreas Dilger <andreas.dilger@...el.com>
Subject: Re: [PATCH 00/15] trivial: Drop unlikely before IS_ERR(_OR_NULL)

On Fri, 31 Jul 2015 13:23:10 +0300
"Kirill A. Shutemov" <kirill@...temov.name> wrote:

> On Fri, Jul 31, 2015 at 11:41:09AM +0200, Vlastimil Babka wrote:
> > On 07/31/2015 10:38 AM, Viresh Kumar wrote:
> > >Hi,
> > >
> > >This cleans up the usage of IS_ERR(_OR_NULL)(), where the callers have
> > >added additional unlikely compiler flag to them. It also fixes the
> > >definition of IS_ERR_OR_NULL(), to use unlikely for all checks it does.
> > 
> > [+CC Steven Rostedt]
> > 
> > Any idea what the compiler does in the case of
> > "if (likely(IS_ERR(...)))"? There are apparently such cases in the source.
> 
> We have two cases in code:
> 
> drivers/rtc/rtc-gemini.c:       if (likely(IS_ERR(rtc->rtc_dev)))
> drivers/staging/lustre/lustre/obdclass/lu_object.c:     if (likely(IS_ERR(shadow) && PTR_ERR(shadow) == -ENOENT)) {
> 
> The first one is mistake, I think. Or do we expect rtc_device_register()
> to fail?
> 
> The second is redundant. "if (PTR_ERR(shadow) == -ENOENT)" should do the
> job.
> 

Yep, those look like bugs to me.

-- Steve
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/