linux-kernel - Re: [PATCH] [4.2 fix] x86, mpx: do not set ->vm

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20150803213912.GA15778@node.dhcp.inet.fi>
Date:	Tue, 4 Aug 2015 00:39:13 +0300
From:	"Kirill A. Shutemov" <kirill@...temov.name>
To:	Greg KH <greg@...ah.com>
Cc:	"Kirill A. Shutemov" <kirill.shutemov@...ux.intel.com>,
	Dave Hansen <dave@...1.net>, dave.hansen@...ux.intel.com,
	luto@...capital.net, tglx@...utronix.de, x86@...nel.org,
	stable@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] [4.2 fix] x86, mpx: do not set ->vm_ops on mpx VMAs

On Mon, Aug 03, 2015 at 01:36:23PM -0700, Greg KH wrote:
> On Mon, Aug 03, 2015 at 10:40:55PM +0300, Kirill A. Shutemov wrote:
> > On Mon, Aug 03, 2015 at 09:19:14AM -0700, Greg KH wrote:
> > > On Mon, Aug 03, 2015 at 01:34:28PM +0300, Kirill A. Shutemov wrote:
> > > > Greg KH wrote:
> > > > > On Mon, Jul 20, 2015 at 02:29:58PM -0700, Dave Hansen wrote:
> > > > > > 
> > > > > > (sorry for the spam, I screwed up the stable@ address).
> > > > > > 
> > > > > > BTW, thanks to Kirill for doing this patch!  He posted it to LKML
> > > > > > but we need to ensure it is picked up for 4.2 and any -stable
> > > > > > kernels where this commit is applied:
> > > > > > 
> > > > > >     	6b7339f4: mm: avoid setting up anonymous pages into file mapping
> > > > > > 
> > > > > > That broke MPX support because MPX sets a vma->vm_ops on an
> > > > > > anonymous VMA.  We need this patch to make it work again,
> > > > > > basically removing MPX's use of ->vm_ops.  Kirill made me aware
> > > > > > of this long ago, but I didn't double-check that his fix got
> > > > > > submitted and merged.
> > > > > > 
> > > > > > I (Dave) fixed up a minor merge conflict and added the
> > > > > > try_unmap_single_bt() use of is_mpx_vma() (which were added
> > > > > > post-4.1).
> > > > > > 
> > > > > > Note for -stable: The first hunk may not apply cleanly because of
> > > > > > other activity in arch/x86/mm/mmap.c, but should be trivial to
> > > > > > apply by hand.  Hunk #5 on mpx.c is only present on 4.2-rc kernels.
> > > > > 
> > > > > Can someone send a version that is known to apply, you don't want to
> > > > > rely on me to get it right :)
> > > > 
> > > > Here it is.
> > > > 
> > > > MPX support was introduced in 3.19, so it only need to be applied to
> > > > 4.1-stable.
> > > 
> > > Thanks, now applied.
> > 
> > Just to make clear: we don't need MPX patch for older stables, but we
> > *do* need 6b7339f4 (mm: avoid setting up anonymous pages into file
> > mapping) to be ported into all stables.
> 
> Can you provide that backport, it isn't a direct cherry-pick.

Patches are in attach.

0001-mm-avoid-setting-up-anonymous-pages-3.18.patch is rebased onto v3.18.

0001-mm-avoid-setting-up-anonymous-pages-3.14.patch is rebased onto v3.14,
also applies cleanly to v3.12, v3.10, v3.4, v3.2.

0001-mm-avoid-setting-up-anonymous-pages-2.6.32.patch is rebased onto
v2.6.32.

Build tested for all these versions.

-- 
 Kirill A. Shutemov

View attachment "0001-mm-avoid-setting-up-anonymous-pages-3.18.patch" of type "text/plain" (2531 bytes)

View attachment "0001-mm-avoid-setting-up-anonymous-pages-3.14.patch" of type "text/plain" (2474 bytes)

View attachment "0001-mm-avoid-setting-up-anonymous-pages-2.6.32.patch" of type "text/plain" (2497 bytes)