linux-kernel - Re: [PATCH 9/9] usb: misc: ftdi-elan: Simplify return statement

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 4 Aug 2015 13:03:17 +0300
From:	Sergei Shtylyov <sergei.shtylyov@...entembedded.com>
To:	"Karajgaonkar, Saurabh (S.)" <skarajga@...teon.com>,
	"srinivas.kandagatla@...il.com" <srinivas.kandagatla@...il.com>,
	"maxime.coquelin@...com" <maxime.coquelin@...com>,
	"patrice.chotard@...com" <patrice.chotard@...com>,
	"stern@...land.harvard.edu" <stern@...land.harvard.edu>,
	"gregkh@...uxfoundation.org" <gregkh@...uxfoundation.org>,
	"mathias.nyman@...el.com" <mathias.nyman@...el.com>,
	"balbi@...com" <balbi@...com>,
	"johan@...nel.org" <johan@...nel.org>,
	"Julia.Lawall@...6.fr" <Julia.Lawall@...6.fr>,
	"khilman@...aro.org" <khilman@...aro.org>,
	"rafael.j.wysocki@...el.com" <rafael.j.wysocki@...el.com>,
	"pmladek@...e.cz" <pmladek@...e.cz>,
	"wsa@...-dreams.de" <wsa@...-dreams.de>
Cc:	"linux-arm-kernel@...ts.infradead.org" 
	<linux-arm-kernel@...ts.infradead.org>,
	"kernel@...inux.com" <kernel@...inux.com>,
	"linux-usb@...r.kernel.org" <linux-usb@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 9/9] usb: misc: ftdi-elan: Simplify return statement

Hello.

On 8/4/2015 12:12 PM, Karajgaonkar, Saurabh (S.) wrote:

> From: Saurabh Karajgaonkar <skarajga@...teon.com>

> Replace redundant variable use in return statement.

> Signed-off-by: Saurabh Karajgaonkar <skarajga@...teon.com>
> ---
>   drivers/usb/misc/ftdi-elan.c | 10 ++--------
>   1 file changed, 2 insertions(+), 8 deletions(-)

> diff --git a/drivers/usb/misc/ftdi-elan.c b/drivers/usb/misc/ftdi-elan.c
> index 8ab1f8f..1545f12 100644
> --- a/drivers/usb/misc/ftdi-elan.c
> +++ b/drivers/usb/misc/ftdi-elan.c
> @@ -2568,11 +2568,8 @@ static int ftdi_elan_close_controller(struct usb_ftdi *ftdi, int fn)
>   					    0x00);
>   	if (UxxxStatus)
>   		return UxxxStatus;
> -	UxxxStatus = ftdi_elan_read_config(ftdi, activePCIfn | reg, 0,
> +	return ftdi_elan_read_config(ftdi, activePCIfn | reg, 0,
>   					   &pcidata);

    Please keep the continuation line aligned by starting it under 'ftdi'.

[...]
> @@ -2695,11 +2692,8 @@ static int ftdi_elan_setupOHCI(struct usb_ftdi *ftdi)
>   		}
>   	}
>   	if (ftdi->function > 0) {
> -		UxxxStatus = ftdi_elan_setup_controller(ftdi,
> +		return ftdi_elan_setup_controller(ftdi,
>   							ftdi->function - 1);

    Likewise.

[...]

MBR, Sergei

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/