linux-kernel - Re: [PATCH 4/9] usb: host: ehci-st: Simplify return statement

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <55C0AED0.7080303@st.com>
Date:	Tue, 4 Aug 2015 14:23:44 +0200
From:	Patrice Chotard <patrice.chotard@...com>
To:	"Karajgaonkar, Saurabh (S.)" <skarajga@...teon.com>,
	"srinivas.kandagatla@...il.com" <srinivas.kandagatla@...il.com>,
	"maxime.coquelin@...com" <maxime.coquelin@...com>,
	"stern@...land.harvard.edu" <stern@...land.harvard.edu>,
	"gregkh@...uxfoundation.org" <gregkh@...uxfoundation.org>,
	"mathias.nyman@...el.com" <mathias.nyman@...el.com>,
	"balbi@...com" <balbi@...com>,
	"johan@...nel.org" <johan@...nel.org>,
	"sergei.shtylyov@...entembedded.com" 
	<sergei.shtylyov@...entembedded.com>,
	"Julia.Lawall@...6.fr" <Julia.Lawall@...6.fr>,
	"khilman@...aro.org" <khilman@...aro.org>,
	"rafael.j.wysocki@...el.com" <rafael.j.wysocki@...el.com>,
	"pmladek@...e.cz" <pmladek@...e.cz>,
	"wsa@...-dreams.de" <wsa@...-dreams.de>
CC:	"linux-arm-kernel@...ts.infradead.org" 
	<linux-arm-kernel@...ts.infradead.org>,
	"kernel@...inux.com" <kernel@...inux.com>,
	"linux-usb@...r.kernel.org" <linux-usb@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 4/9] usb: host: ehci-st: Simplify return statement

Hi

On 08/04/2015 11:10 AM, Karajgaonkar, Saurabh (S.) wrote:
> From: Saurabh Karajgaonkar <skarajga@...teon.com>
>
> Replace redundant variable use in return statement.
>
> Signed-off-by: Saurabh Karajgaonkar <skarajga@...teon.com>
> ---
>   drivers/usb/host/ehci-st.c | 7 +------
>   1 file changed, 1 insertion(+), 6 deletions(-)
>
> diff --git a/drivers/usb/host/ehci-st.c b/drivers/usb/host/ehci-st.c
> index 7e4bd39..b7c5cfa 100644
> --- a/drivers/usb/host/ehci-st.c
> +++ b/drivers/usb/host/ehci-st.c
> @@ -54,7 +54,6 @@ static int st_ehci_platform_reset(struct usb_hcd *hcd)
>   	struct platform_device *pdev = to_platform_device(hcd->self.controller);
>   	struct usb_ehci_pdata *pdata = dev_get_platdata(&pdev->dev);
>   	struct ehci_hcd *ehci = hcd_to_ehci(hcd);
> -	int retval;
>   	u32 threshold;
>   
>   	/* Set EHCI packet buffer IN/OUT threshold to 128 bytes */
> @@ -62,11 +61,7 @@ static int st_ehci_platform_reset(struct usb_hcd *hcd)
>   	writel(threshold, hcd->regs + AHB2STBUS_INSREG01);
>   
>   	ehci->caps = hcd->regs + pdata->caps_offset;
> -	retval = ehci_setup(hcd);
> -	if (retval)
> -		return retval;
> -
> -	return 0;
> +	return ehci_setup(hcd);
>   }
>   
>   static int st_ehci_platform_power_on(struct platform_device *dev)


Acked-by: Patrice Chotard <patrice.chotard@...com>

Thanks

Patrice
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/