linux-kernel - Re: [TRIVIAL PATCH] block: Correct misuses of 0x%<decimal>

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <EB2039AE-8999-4D0F-9602-CA5ACF3F66BA@gmail.com>
Date:	Tue, 4 Aug 2015 10:19:42 +0800
From:	yalin wang <yalin.wang2010@...il.com>
To:	Joe Perches <joe@...ches.com>
Cc:	Don Brace <don.brace@...s.com>,
	open list <linux-kernel@...r.kernel.org>,
	iss_storagedev@...com, storagedev@...s.com,
	linux-scsi <linux-scsi@...r.kernel.org>
Subject: Re: [TRIVIAL PATCH] block: Correct misuses of 0x%<decimal>

Ping ? 
> On Aug 3, 2015, at 16:56, yalin wang <yalin.wang2010@...il.com> wrote:
> 
> 
>> On Aug 3, 2015, at 16:03, Joe Perches <joe@...ches.com> wrote:
>> 
>> On Mon, 2015-08-03 at 15:25 +0800, yalin wang wrote:
>>>> On Aug 3, 2015, at 04:25, Joe Perches <joe@...ches.com> wrote:
>>>> 
>>>> Correct misuse of 0x%d in logging messages.
>>>> 
>> []
>>> why not use like this : dev_dbg(&h->pdev->dev, "   Max outstanding 
>>> commands = %#x\n”  ? 
>>> %#x will add 0x prefix automatically .
>> 
>> It's generally a consistency thing.
>> A 0 value would be emitted as 0 and not 0x0.
>> 
> i try on my ubuntu , 
> 
> static int __init throtl_init(void)                                                                                                           
>  {                                                                                
>         printk("module init test: %#x %p\n", 0, (void *)0x123);                  
>          return 0;                                                                   
> 
>  }                                                                                   
> 
>  module_init(throtl_init); 
> 
> #uname -a
> Linux ubuntu 3.16.0-38-generic #52~14.04.1-Ubuntu SMP Fri May 8 09:43:57 UTC 2015 x86_64 x86_64 x86_64 GNU/Linux
> 
> #dmesg
> [259356.375586] module init test: 0x0 0000000000000123
> 
> it seems don’t need 0x%x for 0, just need %#x for all numbers.
> there are lots of use like this, i can change them if needed:
> 
> # egrep -r  -i '0x%\d*x'  .  | wc -l 
> 11776
> 
> 
> Thanks
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/