linux-kernel - Re: [PATCH 5/8] watchdog: imx2: Convert to use infrastructure triggered keepalives

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20150804154422.GU9999@pengutronix.de>
Date:	Tue, 4 Aug 2015 17:44:22 +0200
From:	Uwe Kleine-König 
	<u.kleine-koenig@...gutronix.de>
To:	Guenter Roeck <linux@...ck-us.net>
Cc:	linux-watchdog@...r.kernel.org, Wim Van Sebroeck <wim@...ana.be>,
	linux-kernel@...r.kernel.org,
	Timo Kokkonen <timo.kokkonen@...code.fi>,
	linux-doc@...r.kernel.org, Jonathan Corbet <corbet@....net>
Subject: Re: [PATCH 5/8] watchdog: imx2: Convert to use infrastructure
 triggered keepalives

Hello,

On Mon, Aug 03, 2015 at 07:13:31PM -0700, Guenter Roeck wrote:
> The watchdog infrastructure now supports handling watchdog keepalive
> if the watchdog is running while the watchdog device is closed.
> Convert the driver to use this infrastructure.
> 
> Signed-off-by: Guenter Roeck <linux@...ck-us.net>
> ---
>  drivers/watchdog/imx2_wdt.c | 72 ++++++++-------------------------------------

I tested the series on an i.MX27 machine and it works nicely. When the
watchdog is already running at probe time it is constantly pinged until
userspace opens /dev/watchdog. With the patch I sent earlier today the
functionallity is also given, that is the machine resets iff I stop
pinging. And when I do a stopping-close the worker looks for this in
hardware non-stoppable device.

Very nice, and also \o/ for the diffstat,
Uwe

-- 
Pengutronix e.K.                           | Uwe Kleine-König            |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/