lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Wed, 5 Aug 2015 08:57:05 +0900 From: Sergey Senozhatsky <sergey.senozhatsky.work@...il.com> To: Salah Triki <salah.triki@....org> Cc: minchan@...nel.org, ngupta@...are.org, linux-kernel@...r.kernel.org, Sergey Senozhatsky <sergey.senozhatsky.work@...il.com>, Sergey Senozhatsky <sergey.senozhatsky@...il.com> Subject: Re: [PATCH] zram: Replace pr_* with dev_* On (08/05/15 08:42), Sergey Senozhatsky wrote: > what's the benefit? and apart from that I don't understand why do you replace some pr_info() with dev_warn(). f.e. [..] > > if (!zcomp_set_max_streams(zram->comp, num)) { > > - pr_info("Cannot change max compression streams\n"); > > + dev_warn(dev, "Cannot change max compression streams to %d", > > + num); ^^^ > > ret = -EINVAL; > > goto out; > > } > > @@ -368,7 +369,7 @@ static ssize_t comp_algorithm_store(struct device *dev, > > down_write(&zram->init_lock); > > if (init_done(zram)) { > > up_write(&zram->init_lock); > > - pr_info("Can't change algorithm for initialized device\n"); > > + dev_warn(dev, "Can't change algorithm for initialized device"); ^^^ [..] and sometimes you don't -- changing pr_info() to dev_info(). > > if (IS_ERR(comp)) { > > - pr_info("Cannot initialise %s compressing backend\n", > > + dev_info(dev, "Cannot initialise %s compressing backend", > > zram->compressor); ^^^ [..] and then again... > > down_write(&zram->init_lock); > > if (init_done(zram)) { > > - pr_info("Cannot change disksize for initialized device\n"); > > + dev_warn(dev, "Cannot change disksize for initialized device"); ^^^ [..] -ss -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists