linux-kernel - Re: [PATCH] zram: Replace pr_* with dev

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1438737365.24137.0.camel@perches.com>
Date:	Tue, 04 Aug 2015 18:16:05 -0700
From:	Joe Perches <joe@...ches.com>
To:	Sergey Senozhatsky <sergey.senozhatsky.work@...il.com>
Cc:	Salah Triki <salah.triki@....org>, minchan@...nel.org,
	ngupta@...are.org, linux-kernel@...r.kernel.org,
	Sergey Senozhatsky <sergey.senozhatsky@...il.com>
Subject: Re: [PATCH] zram: Replace pr_* with dev_*

On Wed, 2015-08-05 at 08:57 +0900, Sergey Senozhatsky wrote:
> On (08/05/15 08:42), Sergey Senozhatsky wrote:
> > what's the benefit?
> 
> and apart from that I don't understand why do you replace some
> pr_info() with dev_warn(). f.e.

And besides that, the formats should not be changed
and still require a '\n' termination to avoid
possible interleaving.

> [..]
> > >  		if (!zcomp_set_max_streams(zram->comp, num)) {
> > > -			pr_info("Cannot change max compression streams\n");
> > > +			dev_warn(dev, "Cannot change max compression streams to %d",
> > > +				num);

etc...

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/