linux-kernel - Re: [PATCH] irqchip/gic: restore global interrupts group settings in distributor

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <55C1D383.2060202@arm.com>
Date:	Wed, 05 Aug 2015 10:12:35 +0100
From:	Marc Zyngier <marc.zyngier@....com>
To:	Anson Huang <b20788@...escale.com>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
CC:	"tglx@...utronix.de" <tglx@...utronix.de>,
	"jason@...edaemon.net" <jason@...edaemon.net>,
	"rmk+kernel@....linux.org.uk" <rmk+kernel@....linux.org.uk>
Subject: Re: [PATCH] irqchip/gic: restore global interrupts group settings
 in distributor

Hi Anson,

On 05/08/15 17:39, Anson Huang wrote:
> In GIC's distributor initializtion, all global interrupts
> are set to group 1, however, after suspend/resume with
> ARM/GIC power off/on, distributor does NOT restore
> these global interrupts group setting, it will cause
> system fail to resume.
> 
> This patch adds global interrupts group setting restore
> for distributor.
> 
> Signed-off-by: Anson Huang <b20788@...escale.com>
> ---
>  drivers/irqchip/irq-gic.c | 10 ++++++++++
>  1 file changed, 10 insertions(+)
> 
> diff --git a/drivers/irqchip/irq-gic.c b/drivers/irqchip/irq-gic.c
> index a530d9a..c8fa6ee 100644
> --- a/drivers/irqchip/irq-gic.c
> +++ b/drivers/irqchip/irq-gic.c
> @@ -532,6 +532,16 @@ static void gic_dist_restore(unsigned int gic_nr)
>  		writel_relaxed(gic_data[gic_nr].saved_spi_enable[i],
>  			dist_base + GIC_DIST_ENABLE_SET + i * 4);
>  
> +	writel_relaxed(GICD_ENABLE_GRP1, dist_base + GIC_DIST_CTRL);
> +
> +	/*
> +	 * Optionally set all global interrupts to be group 1.
> +	 */
> +	if (readl_relaxed(dist_base + GIC_DIST_CTRL) & GICD_ENABLE_GRP1) {
> +		for (i = 32; i < gic_irqs; i += 32)
> +			writel_relaxed(0xffffffff, dist_base + GIC_DIST_IGROUP + i * 4 / 32);
> +	}
> +
>  	writel_relaxed(GICD_ENABLE | GICD_ENABLE_GRP1, dist_base + GIC_DIST_CTRL);
>  }
>  
> 

I'm afraid you'll have to explain a few more things here.

For GICv1/v2, we exclusively use Group0 interrupts when booted in secure
mode (i.e. we don't use FIQ yet, but RMK and Daniel Thompson have
patches for that). When booted in non-secure, the group configuration is
not accessible (it is secure only).

So the first case is not applicable yet, and the second one is not
possible. Which side are you on?

Thanks,

	M.
-- 
Jazz is not dead. It just smells funny...
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/