linux-kernel - Re: [PATCH v2 2/8] xen: Make clear that swiotlb and biomerge are dealing with DMA address

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 5 Aug 2015 11:31:09 +0100
From:	Julien Grall <julien.grall@...rix.com>
To:	Stefano Stabellini <stefano.stabellini@...citrix.com>
CC:	<xen-devel@...ts.xenproject.org>, <ian.campbell@...rix.com>,
	<linux-kernel@...r.kernel.org>,
	Russell King <linux@....linux.org.uk>,
	Konrad Rzeszutek Wilk <konrad.wilk@...cle.com>,
	Boris Ostrovsky <boris.ostrovsky@...cle.com>,
	David Vrabel <david.vrabel@...rix.com>,
	Thomas Gleixner <tglx@...utronix.de>,
	Ingo Molnar <mingo@...hat.com>,
	"H. Peter Anvin" <hpa@...or.com>, <x86@...nel.org>,
	<linux-arm-kernel@...ts.infradead.org>
Subject: Re: [PATCH v2 2/8] xen: Make clear that swiotlb and biomerge are
 dealing with DMA address

Hi Stefano,

On 05/08/15 10:49, Stefano Stabellini wrote:
>>  /* VIRT <-> MACHINE conversion */
>>  #define virt_to_mfn(v)		(pfn_to_mfn(virt_to_pfn(v)))
>> @@ -96,7 +115,7 @@ static inline bool set_phys_to_machine(unsigned long pfn, unsigned long mfn)
>>  
>>  bool xen_arch_need_swiotlb(struct device *dev,
>>  			   unsigned long pfn,
>> -			   unsigned long mfn);
>> +			   unsigned long dfn);
>>  unsigned long xen_get_swiotlb_free_pages(unsigned int order);
> 
> You missed a bunch of dfn->bfn renamings.

Sorry, I forgot to double check that before sending the patch. I will
fix it in the next version.

> Aside from those and the commit message error:
> 
> Reviewed-by: Stefano Stabellini <stefano.stabellini@...citrix.com>

Thank you!

Regards,

-- 
Julien Grall
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/