linux-kernel - Re: [PATCH] acpi, property: Export acpi_dev_prop_read

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <55C24737.8000309@caviumnetworks.com>
Date:	Wed, 5 Aug 2015 10:26:15 -0700
From:	David Daney <ddaney@...iumnetworks.com>
To:	Tomasz Nowicki <tomasz.nowicki@...aro.org>
CC:	"Rafael J. Wysocki" <rjw@...ysocki.net>,
	<linux-kernel@...r.kernel.org>, <linux-acpi@...r.kernel.org>,
	Len Brown <lenb@...nel.org>,
	Robert Richter <rrichter@...ium.com>,
	David Daney <david.daney@...ium.com>
Subject: Re: [PATCH] acpi, property: Export acpi_dev_prop_read_single call.

On 08/05/2015 06:43 AM, Tomasz Nowicki wrote:
> On 05.08.2015 15:48, Rafael J. Wysocki wrote:
>> On Tuesday, August 04, 2015 04:01:59 PM David Daney wrote:
>>> From: Tomasz Nowicki <tomasz.nowicki@...aro.org>
>>>
>>> Fixes the following build error when building drivers as modules:
>>>
>>>   ERROR: "acpi_dev_prop_read_single" [drivers/net/phy/mdio-octeon.ko]
>>> undefined!
>>>   ERROR: "acpi_dev_prop_read_single"
>>> [drivers/net/ethernet/cavium/thunder/thunder_bgx.ko] undefined!
>>
>> Can you please tell me why the drivers in question use that function
>> directly, although they aren't supposed to?
>>
>> Clearly, their authors had not tried to build them as modules or they
>> would have noticed the problem at the development stage already.
>>
>> What would be wrong with using the generic device properties API instead?
>>
> Yes, you are right. We should use:
> int device_property_read_u64_array(struct device *dev, const char
> *propname, u64 *val, size_t nval);
>

Thanks all, for the review and suggestions.  We we try the suggested 
approach and see how it goes...


Thanks again,
David Daney

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/