linux-kernel - Re: [PATCH 00/26] iommu/vt-d: Clean up device<->domain attachment

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1438888787.4023.116.camel@redhat.com>
Date:	Thu, 06 Aug 2015 13:19:47 -0600
From:	Alex Williamson <alex.williamson@...hat.com>
To:	Joerg Roedel <joro@...tes.org>
Cc:	iommu@...ts.linux-foundation.org,
	David Woodhouse <dwmw2@...radead.org>,
	linux-kernel@...r.kernel.org, jroedel@...e.de
Subject: Re: [PATCH 00/26] iommu/vt-d: Clean up device<->domain  attachment

On Wed, 2015-08-05 at 17:18 +0200, Joerg Roedel wrote:
> Hi,
> 
> here is a (bigger than I expected) patch-set which cleans up
> the code to attach and detach domains to iommus in the Intel
> VT-d driver.
> 
> In particular, the patch-set does:
> 
> 	* Remove special cases around the handling of
> 	  various domain types and align their handling
> 	  where possible
> 
> 	* Rework the data structures for the domain<->iommu
> 	  relation to better match with its usage. This
> 	  allowed to get rid of a couple of search loops.
> 
> 	* Make the domain attachment and detachment path
> 	  to/from an iommu more symmetric. This makes the
> 	  code easier to understand and maintain.
> 
> 	* Rework and simplify the locking around the
> 	  domain<->iommu attachment/detachment path.
> 
> A few rough edges and special cases are still left, but I
> expect that these will be removed with the conversion to
> default domains.
> 
> I tested the code with some additional debug code to make
> sure that domain and domain-id allocation/deallocation works
> as expected.
> 
> As test I booted a kernel with the patches (with and
> without iommu=pt) and ran a KVM guest with devices assigned.
> No lockdep warning popped up and the debug output was also
> fine. But of course this is no guarantee that there are no
> issues left, so I am happy about feedback. Please review!

Nice cleanup, Joerg!  A few minor comments in follow-up to the
individual patches.  Thanks,

Alex

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/