linux-kernel - Re: [PATCH] Input: do not emit unneeded EV

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CANLzEkuxOa5od8WURAm9Zn8jQ7Xc5rAhOHKz-cW1YMO797xyoA@mail.gmail.com>
Date:	Thu, 6 Aug 2015 21:10:15 -0700
From:	Benson Leung <bleung@...omium.org>
To:	Dmitry Torokhov <dmitry.torokhov@...il.com>
Cc:	"linux-input@...r.kernel.org" <linux-input@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] Input: do not emit unneeded EV_SYN when suspending

On Thu, Aug 6, 2015 at 7:26 PM, Dmitry Torokhov
<dmitry.torokhov@...il.com> wrote:
> Do not emit EV_SYN/SYN_REPORT on suspend if there were no keys that are
> still pressed as we are suspending the device.

It looks like input_dev_release_keys is used in several other places
other than input_dev_suspend (reset, disconnect, freeze), so maybe
change the commit message to reflect that?

Otherwise, LGTM.


-- 
Benson Leung
Software Engineer, Chrom* OS
bleung@...omium.org
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/