linux-kernel - Re: [PATCH 1/2] sched/deadline: fix comment in push_dl

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <55C9C691.8050407@arm.com>
Date:	Tue, 11 Aug 2015 10:55:29 +0100
From:	Juri Lelli <juri.lelli@....com>
To:	Andrea Parri <parri.andrea@...il.com>,
	Ingo Molnar <mingo@...hat.com>,
	Peter Zijlstra <peterz@...radead.org>
CC:	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 1/2] sched/deadline: fix comment in push_dl_tasks

Hi Andrea,

On 05/08/15 14:56, Andrea Parri wrote:
> The comment is "misleading"; fix it by adapting a comment from
> push_rt_tasks.
> 
> Signed-off-by: Andrea Parri <parri.andrea@...il.com>
> ---
>  kernel/sched/deadline.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/kernel/sched/deadline.c b/kernel/sched/deadline.c
> index 0a17af35..7c17001 100644
> --- a/kernel/sched/deadline.c
> +++ b/kernel/sched/deadline.c
> @@ -1563,7 +1563,7 @@ out:
>  
>  static void push_dl_tasks(struct rq *rq)
>  {
> -	/* Terminates as it moves a -deadline task */
> +	/* push_dl_task will return true if it moved a -deadline task */
>  	while (push_dl_task(rq))
>  		;
>  }
> 

Looks good, thanks!

Best,

- Juri

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/