linux-kernel - Re: [KVM x86 vPMU Patch 0/2] Two vPMU Trivial Patches

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <55CA0C45.7070800@redhat.com>
Date:	Tue, 11 Aug 2015 09:52:53 -0500
From:	Wei Huang <wei@...hat.com>
To:	Paolo Bonzini <pbonzini@...hat.com>, kvm@...r.kernel.org
Cc:	linux-kernel@...r.kernel.org, gleb@...nel.org, tglx@...utronix.de,
	mingo@...hat.com, hpa@...or.com, x86@...nel.org, joro@...tes.org,
	trivial@...nel.org, drjones@...hat.com
Subject: Re: [KVM x86 vPMU Patch 0/2] Two vPMU Trivial Patches



On 8/11/15 08:21, Paolo Bonzini wrote:
>
>
> On 07/08/2015 21:53, Wei Huang wrote:
>> These two trivial patches are related to x86 vPMU code. They were
>> actually suggested by Andrew Jones while he was reviewing the last
>> big vPMU patch set.
>>
>> These patches have been compiled and tested on AMD system using
>> a 64-bit guest VM with various perf commands (e.g. bench, test, top,
>> stat). No obvious problems were found.
>>
>> Thanks,
>> -Wei
>>
>> Wei Huang (2):
>>    KVM: x86/vPMU: Move the definition of kvm_pmu_ops to arch-specific
>>      files
>>    KVM: x86/vPMU: Fix unnecessary signed extesion for AMD PERFCTRn
>>
>>   arch/x86/kvm/pmu.h     | 2 --
>>   arch/x86/kvm/pmu_amd.c | 2 --
>>   arch/x86/kvm/svm.c     | 1 +
>>   arch/x86/kvm/vmx.c     | 1 +
>>   4 files changed, 2 insertions(+), 4 deletions(-)
>>
>
> Applied patch 2.  For patch 1 I'm not sure, because I do not really like
> 1) externs in .c files; 2) globals with no declarations in a .h file.
> So I'm leaving it out while I think more about it.
Thanks. The first one is minor anyway. I won't complain about it. :-)

-Wei

>
> Paolo
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/