linux-kernel - Re: [PATCH] checkpatch: check Signed-off-by: lines for patches coming from stdin

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Tue, 11 Aug 2015 18:04:14 +0100
From:	Javi Merino <javi.merino@....com>
To:	Joe Perches <joe@...ches.com>
Cc:	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	Petr Mladek <pmladek@...e.cz>,
	Andy Whitcroft <apw@...onical.com>,
	Andrew Morton <akpm@...ux-foundation.org>
Subject: Re: [PATCH] checkpatch: check Signed-off-by: lines for patches
 coming from stdin

On Tue, Aug 11, 2015 at 05:47:49PM +0100, Joe Perches wrote:
> On Tue, 2015-08-11 at 15:20 +0100, Javi Merino wrote:
> > Commit 34d8815f9512 ("checkpatch: add --showfile to allow input via pipe
> > to show filenames") disabled the ability to check for Signed-off-by
> > lines in patches that are fed to scripts/checkpatch.pl from stdin.  This
> > makes things like:
> > 
> > git rebase --interactive --exec 'git format-patch --stdout -1 | scripts/checkpatch.pl --strict -'
> 
> This is akin to running checkpatch on patches to the stable tree.
> Generally unnecessary.

No, the rebase is not moving the base of the patches.  The rebase is to run
checkpatch on every patch before sending it to the list.  It's for
patches aiming mainline.

> I think patches should never be committed without a sign-off so
> the concept of using checkpatch when rebasing is fundamentally
> odd, but <shrug>, different workflows for different folks.

I guess other people run "git format-patch -o blah" and then run
scripts/checkpatch.pl on blah.  As you said, different workflows for
different folks.

Cheers,
Javi
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/