linux-kernel - Re: [PATCH v2] sched,fair: Remove

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20150812111226.GA3192@afzalpc>
Date:	Wed, 12 Aug 2015 16:42:27 +0530
From:	Afzal Mohammed <afzal.mohd.ma@...il.com>
To:	linux-kernel@...r.kernel.org
Cc:	Ingo Molnar <mingo@...hat.com>,
	Peter Zijlstra <peterz@...radead.org>
Subject: Re: [PATCH v2] sched,fair: Remove > u32 weight handling for delta

Hi Peter,

On Mon, Jul 06, 2015 at 11:49:15PM +0530, Afzal Mohammed wrote:
> scaled down weight 'fact' would not be > u32 rather than unlikely as the
> weight being passed in __calc_delta() is either 'se->load.weight' or
> NICE_O_LOAD. 'se->load.weight' would be one of the values of
> prio_to_weight[] in the case of task, while in the case of task group it
> would be capped to MAX_SHARES. All those possible values can fit in u32.
> Hence remove the initial > u32 handling on 'fact'.
> 
> Signed-off-by: Afzal Mohammed <afzal.mohd.ma@...il.com>
> ---
> 
> v2: expand change log on why weight can fit in u32, remove incorrect
>     comments.
> 
>  kernel/sched/fair.c | 7 -------
>  1 file changed, 7 deletions(-)

bool __weak patch_adds_some_value(void)
{
        return (~3 asm instruction less for calc_delta) && (less LOC);
}

if (patch_adds_some_value() && revised_message_okay())
        please help $subject reach mainline;

Regards
Afzal
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/