linux-kernel - Re: [PATCH v2 5/5] KVM: refactor asynchronous vcpu ioctl dispatch

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <55CC636C.9080202@redhat.com>
Date:	Thu, 13 Aug 2015 11:29:16 +0200
From:	Paolo Bonzini <pbonzini@...hat.com>
To:	Christian Borntraeger <borntraeger@...ibm.com>,
	Radim Krčmář <rkrcmar@...hat.com>,
	linux-kernel@...r.kernel.org
Cc:	kvm@...r.kernel.org
Subject: Re: [PATCH v2 5/5] KVM: refactor asynchronous vcpu ioctl dispatch



On 12/08/2015 22:03, Christian Borntraeger wrote:
>> >  #if defined(CONFIG_S390) || defined(CONFIG_PPC) || defined(CONFIG_MIPS)
>> > -	if (ioctl == KVM_S390_INTERRUPT || ioctl == KVM_S390_IRQ || ioctl == KVM_INTERRUPT)
>> > -		return kvm_arch_vcpu_ioctl(filp, ioctl, arg);
>> > +	case KVM_S390_INTERRUPT:
>> > +	case KVM_S390_IRQ:
>> > +	case KVM_INTERRUPT:
> When you are it you might want to put the KVM_S390* withing CONFIG_S390 and
> KVM_INTERRUPT within CONFIG_PPC || CONFIG_MIPS
> 
> This might speed up the switch statement for s390/ppc/mips a tiny bit. It will add
> another ifdef, though. Paolo?

Sure.  I wasn't sure of KVM_INTERRUPT's usage on s390.

I'm okay with keeping the switch inline too, but if Radim prefers a
function that's also fine.

Paolo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/