linux-kernel - Re: [PATCH v2 1/5] KVM: add kvm_has

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <55CC6370.3080606@redhat.com>
Date:	Thu, 13 Aug 2015 11:29:20 +0200
From:	Paolo Bonzini <pbonzini@...hat.com>
To:	Radim Krčmář <rkrcmar@...hat.com>,
	Christian Borntraeger <borntraeger@...ibm.com>
Cc:	linux-kernel@...r.kernel.org, kvm@...r.kernel.org
Subject: Re: [PATCH v2 1/5] KVM: add kvm_has_request wrapper



On 13/08/2015 11:11, Radim Krčmář wrote:
>> > for the new interface. maybe we can rename kvm_check_request in a separate patch somewhen.
> I wonder why haven't we copied the naming convention from bit operations
> (or if programming would be better if German was its language),
> 
>   kvm_test_request
>   kvm_set_request
>   kvm_clear_request
>   kvm_test_and_clear_request
> 
> The only disadvantage is that
>   kvm_test_and_clear_request
> is longer than
>   kvm_check_request
>                    123456789
> by whooping 9 characters.
> 
> I could live with that.

Yes, that would be much better.

Paolo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/