linux-kernel - Re: [PATCH] Remove unselectable rule for arm-exynos-cpufreq.o

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 13 Aug 2015 19:53:36 +0900
From:	Krzysztof Kozlowski <k.kozlowski@...sung.com>
To:	Jonas Rabenstein <jonas.rabenstein@...dium.uni-erlangen.de>
Cc:	"Rafael J. Wysocki" <rjw@...ysocki.net>,
	Viresh Kumar <viresh.kumar@...aro.org>,
	linux-pm@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] Remove unselectable rule for arm-exynos-cpufreq.o

2015-08-13 19:32 GMT+09:00 Jonas Rabenstein
<jonas.rabenstein@...dium.uni-erlangen.de>:
> With commit 2907ed4377d9 ("cpufreq: exynos: remove Exynos4x12 specific
> cpufreq driver support"), the last specific Exynos-cpufreq driver
> depending on ARM_EXYNOS_CPUFREQ was removed. As there is no
> Exynos-specific cpufreq driver depending on the code in
> drivers/cpufreq/exynos-cpufreq.c (selected by ARM_EXYNOS_CPUFREQ),
> this file was deleted and ARM_EXYNOS_CPUFREQ removed from Kconfig.
> After all, the rule in drivers/cpufreq/Makefile, to combine all
> specific cpufreq drivers depending on the generic code for Exynos into
> one objectfile is obsolete and can be removed.
>
> Remove unselectable rule for arm-exynos-cpufreq.o from
> drivers/cpufreq/Makefile, which - if selectable - would generate an
> always empty objectfile.

That's a lot, really a lot of words, just to say that
ARM_EXYNOS_CPUFREQ option was removed and we should get rid of any
left-overs. The patch is of course valid... but could you trim this to
a short sentence giving the reason? Mentioned commit ID comes from
linux-next (or maintainer branch which may rebase) so it won't work
long-term. I think you can just leave the title of the commit.

When re-spinning:
Reviewed-by: Krzysztof Kozlowski <k.kozlowski@...sung.com>

Viresh,
Do you want this to go through samsung-soc tree?

Best regards,
Krzysztof

>
> Signed-off-by: Jonas Rabenstein <jonas.rabenstein@...dium.uni-erlangen.de>
> ---
> I found this inconsistency using the undertaker and
> undertaker-checkpatch tools (https://undertaker.cs.fau.de/).
>
>  drivers/cpufreq/Makefile | 1 -
>  1 file changed, 1 deletion(-)
>
> diff --git a/drivers/cpufreq/Makefile b/drivers/cpufreq/Makefile
> index bbc4a9f..958be2b 100644
> --- a/drivers/cpufreq/Makefile
> +++ b/drivers/cpufreq/Makefile
> @@ -52,7 +52,6 @@ obj-$(CONFIG_ARM_DT_BL_CPUFREQ)               += arm_big_little_dt.o
>
>  obj-$(CONFIG_ARCH_DAVINCI)             += davinci-cpufreq.o
>  obj-$(CONFIG_UX500_SOC_DB8500)         += dbx500-cpufreq.o
> -obj-$(CONFIG_ARM_EXYNOS_CPUFREQ)       += arm-exynos-cpufreq.o
>  obj-$(CONFIG_ARM_EXYNOS5440_CPUFREQ)   += exynos5440-cpufreq.o
>  obj-$(CONFIG_ARM_HIGHBANK_CPUFREQ)     += highbank-cpufreq.o
>  obj-$(CONFIG_ARM_HISI_ACPU_CPUFREQ)    += hisi-acpu-cpufreq.o
> --
> 2.5.0
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-pm" in
> the body of a message to majordomo@...r.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/