linux-kernel - Re: [PATCH v2 09/16] PM / hibernate: Reserve hibernation key and erase footprints

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1439434143.15722.12.camel@localhost>
Date:	Thu, 13 Aug 2015 02:45:32 +0000
From:	"Chen, Yu C" <yu.c.chen@...el.com>
To:	"joeyli.kernel@...il.com" <joeyli.kernel@...il.com>
CC:	"matthew.garrett@...ula.com" <matthew.garrett@...ula.com>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"jlee@...e.com" <jlee@...e.com>,
	"vojtech@...e.cz" <vojtech@...e.cz>,
	"linux-pm@...r.kernel.org" <linux-pm@...r.kernel.org>,
	"pavel@....cz" <pavel@....cz>,
	"rjw@...ysocki.net" <rjw@...ysocki.net>,
	"jkosina@...e.cz" <jkosina@...e.cz>,
	"mingo@...hat.com" <mingo@...hat.com>,
	"hpa@...or.com" <hpa@...or.com>,
	"linux-efi@...r.kernel.org" <linux-efi@...r.kernel.org>,
	"Brown, Len" <len.brown@...el.com>,
	"jwboyer@...hat.com" <jwboyer@...hat.com>,
	"Fleming, Matt" <matt.fleming@...el.com>
Subject: Re: [PATCH v2 09/16] PM / hibernate: Reserve hibernation key and
 erase footprints

Hi Chun-yi,
On Tue, 2015-08-11 at 14:16 +0800, Lee, Chun-Yi wrote:

> +/* A page used to keep hibernation keys */
> +static struct hibernation_keys *hibernation_keys;
> +
> +void __init parse_hibernation_keys(u64 phys_addr, u32 data_len)
> +{
> +	struct setup_data *hibernation_setup_data;
> +
> +	/* Reserve keys memory, will copy and erase in init_hibernation_keys() */
> +	keys_phys_addr = phys_addr + sizeof(struct setup_data);
> +	memblock_reserve(keys_phys_addr, sizeof(struct hibernation_keys));
> +
> +	/* clear hibernation_data */
> +	hibernation_setup_data = early_memremap(phys_addr, data_len);
> +	if (!hibernation_setup_data)
> +		return;
> +
should we invoke memblock_free if early_memremap failed?

Best Regards,
Yu