linux-kernel - Re: [PATCH 07/19] staging: most: Remove unnecessary externs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20150814105026.GC4496@mwanda>
Date:	Fri, 14 Aug 2015 13:50:26 +0300
From:	Dan Carpenter <dan.carpenter@...cle.com>
To:	Andrey Shvetsov <andrey.shvetsov.ml@...il.com>
Cc:	Joe Perches <joe@...ches.com>, devel@...verdev.osuosl.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 07/19] staging: most: Remove unnecessary externs

On Fri, Aug 14, 2015 at 10:36:35AM +0200, Andrey Shvetsov wrote:
> On Mon, Aug 10, 2015 at 02:51:22PM -0700, Joe Perches wrote:
> > Using 'extern' is not necessary for function prototypes.
> > 
> We use them to mark dependency inversions (callbacks).
> I thought about comments instead of, but I'm not sure what is worse.

I have never heard of anyone using the extern keyword to mean that
before so I feel like it doesn't work as a "putting extern means the
code documents itself".

regards,
dan carpenter

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/