linux-kernel - Re: [PATCH 05/19] staging: iio: Remove unnecessary externs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Sat, 15 Aug 2015 20:57:21 +0100
From:	Jonathan Cameron <jic23@...nel.org>
To:	Lars-Peter Clausen <lars@...afoo.de>,
	Joe Perches <joe@...ches.com>, devel@...verdev.osuosl.org,
	Michael Hennerich <Michael.Hennerich@...log.com>
Cc:	Hartmut Knaack <knaack.h@....de>,
	Peter Meerwald <pmeerw@...erw.net>,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	linux-iio@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 05/19] staging: iio: Remove unnecessary externs

On 11/08/15 19:43, Lars-Peter Clausen wrote:
> On 08/10/2015 11:51 PM, Joe Perches wrote:
>> Using 'extern' is not necessary for function prototypes.
>>
>> Signed-off-by: Joe Perches <joe@...ches.com>
> 
> Acked-by: Lars-Peter Clausen <lars@...afoo.de>
> 
Applied to the togreg branch of iio.git.  4.4 material now
probably.

Thanks,

Jonathan
> Thanks.
> 
>> ---
>>  drivers/staging/iio/meter/ade7854.h | 4 ++--
>>  1 file changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/drivers/staging/iio/meter/ade7854.h b/drivers/staging/iio/meter/ade7854.h
>> index 52ca541..52f4195 100644
>> --- a/drivers/staging/iio/meter/ade7854.h
>> +++ b/drivers/staging/iio/meter/ade7854.h
>> @@ -168,7 +168,7 @@ struct ade7854_state {
>>  
>>  };
>>  
>> -extern int ade7854_probe(struct iio_dev *indio_dev, struct device *dev);
>> -extern int ade7854_remove(struct iio_dev *indio_dev);
>> +int ade7854_probe(struct iio_dev *indio_dev, struct device *dev);
>> +int ade7854_remove(struct iio_dev *indio_dev);
>>  
>>  #endif
>>
> 

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/