linux-kernel - Re: [PATCH] kdbus: create /sys/fs/kdbus with sysfs_create_mount

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 17 Aug 2015 19:23:30 +0200
From:	David Herrmann <dh.herrmann@...il.com>
To:	Lubomir Rintel <lkundrak@...sk>
Cc:	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	Daniel Mack <daniel@...que.org>,
	David Herrmann <dh.herrmann@...glemail.com>,
	Djalal Harouni <tixxdz@...ndz.org>,
	linux-kernel <linux-kernel@...r.kernel.org>,
	"Eric W. Biederman" <ebiederm@...ssion.com>,
	linux-fsdevel <linux-fsdevel@...r.kernel.org>
Subject: Re: [PATCH] kdbus: create /sys/fs/kdbus with sysfs_create_mount_point()

Hi

On Fri, Aug 14, 2015 at 3:21 PM, Lubomir Rintel <lkundrak@...sk> wrote:
> Since 0cbee99269 user-namespace pull, if a kdbusfs is mounted on a
> location that's not created with sysfs_create_mount_point the user
> namespaces are not allowed to mount their sysfs instances.
>
> Signed-off-by: Lubomir Rintel <lkundrak@...sk>
> ---
> Applies on top of char-misc/kdbus a36324913.

This does not apply on top of char-misc/kdbus. The tree lacks the
necessary commits. But yeah, it's required for 4.2. I'll keep it
starred until Greg back-merges 4.2.

Anyway, this is still: Reviewed-by: David Herrmann <dh.herrmann@...il.com>

Thanks!
David

>  ipc/kdbus/main.c | 13 +++++--------
>  1 file changed, 5 insertions(+), 8 deletions(-)
>
> diff --git a/ipc/kdbus/main.c b/ipc/kdbus/main.c
> index 1ad4dc8..c2117ea 100644
> --- a/ipc/kdbus/main.c
> +++ b/ipc/kdbus/main.c
> @@ -75,16 +75,13 @@
>   *  '» struct kdbus_ep *ep (owned)
>   */
>
> -/* kdbus mount-point /sys/fs/kdbus */
> -static struct kobject *kdbus_dir;
> -
>  static int __init kdbus_init(void)
>  {
>         int ret;
>
> -       kdbus_dir = kobject_create_and_add(KBUILD_MODNAME, fs_kobj);
> -       if (!kdbus_dir)
> -               return -ENOMEM;
> +       ret = sysfs_create_mount_point(fs_kobj, KBUILD_MODNAME);
> +       if (ret)
> +               return ret;
>
>         ret = kdbus_fs_init();
>         if (ret < 0) {
> @@ -96,14 +93,14 @@ static int __init kdbus_init(void)
>         return 0;
>
>  exit_dir:
> -       kobject_put(kdbus_dir);
> +       sysfs_remove_mount_point(fs_kobj, KBUILD_MODNAME);
>         return ret;
>  }
>
>  static void __exit kdbus_exit(void)
>  {
>         kdbus_fs_exit();
> -       kobject_put(kdbus_dir);
> +       sysfs_remove_mount_point(fs_kobj, KBUILD_MODNAME);
>         ida_destroy(&kdbus_node_ida);
>  }
>
> --
> 2.4.3
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/