linux-kernel - Re: [PATCH] lpfc: Fix possible use-after-free and double free in lpfc_mbx_cmpl_rdp_page

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <mqdfv3h5cia.fsf@c203.arch.suse.de>
Date:	Tue, 18 Aug 2015 08:36:29 +0200
From:	Johannes Thumshirn <jthumshirn@...e.de>
To:	Sebastian Herbszt <herbszt@....de>
Cc:	James Smart <james.smart@...gotech.com>,
	Dick Kennedy <dick.kennedy@...gotech.com>,
	"James E.J. Bottomley" <JBottomley@...n.com>,
	linux-scsi@...r.kernel.org, linux-kernel@...r.kernel.org,
	Colin King <colin.king@...onical.com>
Subject: Re: [PATCH] lpfc: Fix possible use-after-free and double free in lpfc_mbx_cmpl_rdp_page_a2()

Sebastian Herbszt <herbszt@....de> writes:

> Johannes Thumshirn wrote:
>> If the bf_get() call in lpfc_mbx_cmpl_rdp_page_a2() does succeeds, execution
>> continues normally and mp gets kfree()d.
>> 
>> If the subsequent call to lpfc_sli_issue_mbox() fails execution jumps to the
>> error label where lpfc_mbuf_free() is called with mp->virt and mp->phys as
>> function arguments. This is the use after free. Following the use after free mp
>> gets kfree()d again which is a double free.
>
> A similar patch was posted by Colin Ian King on 2015-07-31 [1].
>
> [1] http://marc.info/?l=linux-scsi&m=143835937206204&w=2

OK,

Is it already in James' tree (haven't checked)? The problematic code was
merged for 4.2-rc1 so if the fix (Collin's or mine I don't care) could go
in while we're still in the rc phase, we could avoid all that stable
circus.

Thanks for digging this out.

Byte,
        Johannes
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/