linux-kernel - Re: [PATCH] gpio:Fix error handling in the function max732x_irq_bus_sync

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <CAAVeFuLutUgFfTZYRce3GKofnvw94mzvaZSER9WmorNRXuzW-Q@mail.gmail.com>
Date:	Tue, 18 Aug 2015 16:37:45 +0900
From:	Alexandre Courbot <gnurou@...il.com>
To:	Nicholas Krause <xerofoify@...il.com>
Cc:	Linus Walleij <linus.walleij@...aro.org>,
	"linux-gpio@...r.kernel.org" <linux-gpio@...r.kernel.org>,
	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] gpio:Fix error handling in the function max732x_irq_bus_sync_unlock

On Tue, Aug 18, 2015 at 3:37 AM, Nicholas Krause <xerofoify@...il.com> wrote:
> This fixes error handling in the function max732x_irq_bus_sync_unlock
> by checking if the internal call in this function's while loop to the
> function max732x_gpio_direction_input failed by returning a error code
> and if so break out of this while immediately as we cannot continue
> after a failed call to this function before finally unlocking the
> locked mutex and returning to the caller of the function,
> max732x_irq_bus_sync_unlock.

Again a overlenghty one-line commit message.

The intent is also debattable. max732x_irq_bus_sync_unlock() returns
void, so we have to way to inform the caller that some failure
happened. In that case, isn't it better to keep doing the job as much
as we can? max732x_gpio_direction_input() already signals errors, so
all that we can do here is done already.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/