linux-kernel - Re: IDE Floppy support for IOMEGA Zip Drive broken in 3.16 -> 3.17 transition

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 18 Aug 2015 09:44:28 +0200
From:	Sergio Callegari <sergio.callegari@...il.com>
To:	Borislav Petkov <bp@...en8.de>
CC:	hch@...radead.org, linux-kernel@...r.kernel.org
Subject: Re: IDE Floppy support for IOMEGA Zip Drive broken in 3.16 -> 3.17
 transition

Hi,

I have bisected the issue down to

[045065d8a300a37218c548e9aa7becd581c6a0e8] [SCSI] fix qemu boot hang problem

Bisecting has been a painful job due to the fact that the bug may show only many 
hours after the system boot.

The commit above in fact is not the culprit, but a fix to an issue that was 
hiding the real bug on my system.  See

http://marc.info/?l=linux-kernel&m=143973820612978&w=2

The real issue is with sata host lock and seems to be biting a few other people 
as well

https://bbs.archlinux.org/viewtopic.php?id=189324

A patch fixing the issue was sent to the LKML back in Nov 2014 by Christoph 
Hellwig (who is reading in CC)

https://lkml.org/lkml/2014/11/20/581

I have tested the patch and it works for me.

What is expected to happen now?

The original patch appeared to have been dropped and did not make it to the 
mainline kernel (is there any reason why, some contraindication?), but seems to 
be important because without it the linux kernel is broken on some systems.

Is there anything that can be done for the patch be accepted in mainline and 
stabilization kernels?

Best regards,

Sergio



On 25/06/2015 23:31, Borislav Petkov wrote:
> On Thu, Jun 25, 2015 at 08:58:58PM +0000, Sergio Callegari wrote:
>> What has changed wrt IDE in 3.16->3.17 transition? Why is the issue present
>> even when the drive is not used (unmounted)?  How can I help diagnosing?
>
> Here's what went into ide in 3.17:
>
> $ git log -p v3.16..v3.17 drivers/ide/
> commit a53dae49b2fea43d8f4ec5aeca0e288bbc8d6895
> Author: Christoph Jaeger <christophjaeger@...ux.com>
> Date:   Wed Apr 9 09:28:01 2014 +0200
>
>      ide: use module_platform_driver()
>
>      Eliminate boilerplate code by using module_platform_driver().
>
>      Signed-off-by: Christoph Jaeger <christophjaeger@...ux.com>
>      Signed-off-by: David S. Miller <davem@...emloft.net>
>
> diff --git a/drivers/ide/au1xxx-ide.c b/drivers/ide/au1xxx-ide.c
> index 259786ca8b75..07ea58084068 100644
> --- a/drivers/ide/au1xxx-ide.c
> +++ b/drivers/ide/au1xxx-ide.c
> ...
>
> and that driver doesn't have anything to do with zip drives.
>
> So problem is either somewhere else in the kernel or maybe something's
> missing from the 3.17 config or somewhere completely different.
>
> You could bisect the kernels between 3.16 and 3.17 - unless someone has
> a better idea...
>

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/