linux-kernel - Re: [PATCH] dma-mapping: harmonize definition of DMA_ERROR

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Tue, 18 Aug 2015 10:10:16 +0200
From:	Marek Szyprowski <m.szyprowski@...sung.com>
To:	Nicholas Mc Guire <hofrat@...dl.org>,
	Russell King <linux@....linux.org.uk>
Cc:	Arnd Bergmann <arnd@...db.de>, Will Deacon <will.deacon@....com>,
	Catalin Marinas <catalin.marinas@....com>,
	Stefano Stabellini <stefano.stabellini@...citrix.com>,
	Thierry Reding <treding@...dia.com>,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] dma-mapping: harmonize definition of DMA_ERROR_CODE

Hello,

On 2015-06-10 10:41, Nicholas Mc Guire wrote:
> All architectures except arm that define DMA_ERROR_CODE are casting it
> to (dma_addr_t) - as it is always compared to dma_addr_t in arm as well
> this could be harmonized.
>
> Signed-off-by: Nicholas Mc Guire <hofrat@...dl.org>

Acked-by: Marek Szyprowski <m.szyprowski@...sung.com>

> ---
>
> This also fixes the build warning in
> ./arch/arm/include/asm/dma-mapping.h: In function 'dma_mapping_error':
> ./arch/arm/include/asm/dma-mapping.h:176:18: warning: comparison between
> signed and unsigned integer expressions [-Wsign-compare]
>
> While it fixes this build warning it causes another build warning - so
> from that perspective its not much of an improvement - never the less
> having this harmonized with all other archs makes sense I think.
>
> Patch was compile tested with exynos_defconfig
>
> Patch is against 4.1-rc7 (localversion-next is -next-20150609)
>
>   arch/arm/include/asm/dma-mapping.h |    2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm/include/asm/dma-mapping.h b/arch/arm/include/asm/dma-mapping.h
> index b52101d..68e41e8 100644
> --- a/arch/arm/include/asm/dma-mapping.h
> +++ b/arch/arm/include/asm/dma-mapping.h
> @@ -14,7 +14,7 @@
>   #include <xen/xen.h>
>   #include <asm/xen/hypervisor.h>
>   
> -#define DMA_ERROR_CODE	(~0)
> +#define DMA_ERROR_CODE	(~(dma_addr_t)0x0)
>   extern struct dma_map_ops arm_dma_ops;
>   extern struct dma_map_ops arm_coherent_dma_ops;
>   

Best regards
-- 
Marek Szyprowski, PhD
Samsung R&D Institute Poland

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/