linux-kernel - Re: [PATCH v1 8/8] scsi: ufs-qcom: add QUniPro hardware support and power optimizations

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAC5umyh-V_95zy_d_Z3h_q-OxadHpAGBaKJrGAV+=EJ-w_T27w@mail.gmail.com>
Date:	Tue, 18 Aug 2015 23:15:30 +0900
From:	Akinobu Mita <akinobu.mita@...il.com>
To:	Yaniv Gardi <ygardi@...eaurora.org>
Cc:	robherring2@...il.com,
	Jej B <James.Bottomley@...senpartnership.com>,
	Paul Bolle <pebolle@...cali.nl>,
	Christoph Hellwig <hch@...radead.org>,
	LKML <linux-kernel@...r.kernel.org>,
	"linux-scsi@...r.kernel.org" <linux-scsi@...r.kernel.org>,
	linux-arm-msm@...r.kernel.org, Santosh Y <santoshsy@...il.com>,
	linux-scsi-owner@...r.kernel.org,
	Subhash Jadavani <subhashj@...eaurora.org>,
	Gilad Broner <gbroner@...eaurora.org>,
	Dolev Raviv <draviv@...eaurora.org>,
	Vinayak Holikatti <vinholikatti@...il.com>,
	"James E.J. Bottomley" <JBottomley@...n.com>
Subject: Re: [PATCH v1 8/8] scsi: ufs-qcom: add QUniPro hardware support and
 power optimizations

Hi Yaniv,

2015-08-16 19:14 GMT+09:00 Yaniv Gardi <ygardi@...eaurora.org>:
> @@ -708,17 +713,18 @@ static inline u32 ufshcd_vops_get_ufs_hci_version(struct ufs_hba *hba)
>         return ufshcd_readl(hba, REG_UFS_VERSION);
>  }
>
> -static inline void ufshcd_vops_clk_scale_notify(struct ufs_hba *hba)
> +static inline int ufshcd_vops_clk_scale_notify(struct ufs_hba *hba,
> +                                               bool up, bool status)
>  {
>         if (hba->vops && hba->vops->clk_scale_notify)
> -               return hba->vops->clk_scale_notify(hba);
> +               return hba->vops->clk_scale_notify(hba, up, status);
> +       return 0;
>  }

The third argument of clk_scale_notify() vops is PRE_CHANGE or
POST_CHANGE.  So should it also be converted from bool to enum
ufs_notify_change_status like other vops does?
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/