linux-kernel - RE: linux-next: Tree for Aug 17 (staging/hfi1)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <32E1700B9017364D9B60AED9960492BC257995D2@fmsmsx120.amr.corp.intel.com>
Date:	Tue, 18 Aug 2015 14:24:32 +0000
From:	"Marciniszyn, Mike" <mike.marciniszyn@...el.com>
To:	Randy Dunlap <rdunlap@...radead.org>,
	Stephen Rothwell <sfr@...b.auug.org.au>,
	"linux-next@...r.kernel.org" <linux-next@...r.kernel.org>,
	Doug Ledford <dledford@...hat.com>
CC:	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"devel@...verdev.osuosl.org" <devel@...verdev.osuosl.org>
Subject: RE: linux-next: Tree for Aug 17 (staging/hfi1)

> A:  these and other similar errors:
> 
> In file included from ../drivers/staging/hfi1/chip.c:61:0:
> ../drivers/staging/hfi1/chip.c: In function â__hfi1_trace_LINKVERBâ:
> ../drivers/staging/hfi1/trace.h:1357:20: error: function
> â__hfi1_trace_LINKVERBâ can never be inlined because it uses variable
> argument lists  static inline void __hfi1_trace_##fn(const char *func, char
> *fmt, ...) \
>

This was corrected with
https://www.mail-archive.com/linux-rdma@vger.kernel.org/msg27221.html, which I think Doug has picked up.

Doug, Randy, Stephen how do we want to handle fixing drivers/staging/hfi1 via the staging list vs. the linux-rdma list?

> B:  When CONFIG_PCI is not enabled, lots of these errors:
> 

The driver used to get a gift from the drivers/infiniband/hw/Kconfig, which has the required PCI dependency.

The infiniband dependency is also similarly missing and was resolved via the following temporary patch:

https://www.mail-archive.com/linux-rdma@vger.kernel.org/msg26989.html

This one also needs to be similarly added for that 0-day build issue.

I have submitted to both lists https://www.mail-archive.com/linux-rdma@vger.kernel.org/msg27299.html assuming the above one as a dependency.

> In file included from ../drivers/staging/hfi1/chip.c:60:0:
> ../drivers/staging/hfi1/hfi.h:508:20: error: field âmsixâ has incomplete
> type
>   struct msix_entry msix;
>                    ^
> 
> ../drivers/staging/hfi1/chip.c: In function âdisable_intxâ:
> ../drivers/staging/hfi1/chip.c:8667:2: error: implicit declaration of function
> âpci_intxâ [-Werror=implicit-function-declaration]
>   pci_intx(pdev, 0);
>   ^
> 
> so the driver should depend on PCI or maybe even PCI_MSI.
> 
> C.  Please provide some contact info, e.g. in a TODO file or the MAINTAINERS
> file.
> 

I have submitted https://www.mail-archive.com/linux-rdma@vger.kernel.org/msg27298.html to both lists to add a maintainer.

Mike