linux-kernel - Re: linux-next: Tree for Aug 17 (staging/hfi1)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <55D261CA.2070802@infradead.org>
Date:	Mon, 17 Aug 2015 15:35:54 -0700
From:	Randy Dunlap <rdunlap@...radead.org>
To:	Stephen Rothwell <sfr@...b.auug.org.au>, linux-next@...r.kernel.org
Cc:	linux-kernel@...r.kernel.org,
	"devel@...verdev.osuosl.org" <devel@...verdev.osuosl.org>,
	Mike Marciniszyn <mike.marciniszyn@...el.com>
Subject: Re: linux-next: Tree for Aug 17 (staging/hfi1)

On 08/17/15 03:55, Stephen Rothwell wrote:
> Hi all,
> 
> Changes since 20150813:
> 


Several items:

A:  these and other similar errors:

In file included from ../drivers/staging/hfi1/chip.c:61:0:
../drivers/staging/hfi1/chip.c: In function â__hfi1_trace_LINKVERBâ:
../drivers/staging/hfi1/trace.h:1357:20: error: function â__hfi1_trace_LINKVERBâ can never be inlined because it uses variable argument lists
 static inline void __hfi1_trace_##fn(const char *func, char *fmt, ...) \
                    ^
../drivers/staging/hfi1/chip.c: In function â__hfi1_trace_CNTRâ:
../drivers/staging/hfi1/trace.h:1357:20: error: function â__hfi1_trace_CNTRâ can never be inlined because it uses variable argument lists
 static inline void __hfi1_trace_##fn(const char *func, char *fmt, ...) \
                    ^
../drivers/staging/hfi1/chip.c: In function â__hfi1_trace_DC8051â:
../drivers/staging/hfi1/trace.h:1357:20: error: function â__hfi1_trace_DC8051â can never be inlined because it uses variable argument lists
 static inline void __hfi1_trace_##fn(const char *func, char *fmt, ...) \
                    ^
../drivers/staging/hfi1/chip.c: In function â__hfi1_trace_RCVCTRLâ:
../drivers/staging/hfi1/trace.h:1357:20: error: function â__hfi1_trace_RCVCTRLâ can never be inlined because it uses variable argument lists
 static inline void __hfi1_trace_##fn(const char *func, char *fmt, ...) \
                    ^
../drivers/staging/hfi1/chip.c: In function â__hfi1_trace_TIDâ:
../drivers/staging/hfi1/trace.h:1357:20: error: function â__hfi1_trace_TIDâ can never be inlined because it uses variable argument lists
 static inline void __hfi1_trace_##fn(const char *func, char *fmt, ...) \
                    ^

B:  When CONFIG_PCI is not enabled, lots of these errors:

In file included from ../drivers/staging/hfi1/chip.c:60:0:
../drivers/staging/hfi1/hfi.h:508:20: error: field âmsixâ has incomplete type
  struct msix_entry msix;
                   ^

../drivers/staging/hfi1/chip.c: In function âdisable_intxâ:
../drivers/staging/hfi1/chip.c:8667:2: error: implicit declaration of function âpci_intxâ [-Werror=implicit-function-declaration]
  pci_intx(pdev, 0);
  ^

so the driver should depend on PCI or maybe even PCI_MSI.

C.  Please provide some contact info, e.g. in a TODO file or the MAINTAINERS file.


-- 
~Randy
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/