linux-kernel - Re: [PATCH] leds: leds-fsg: Use devm_led_classdev

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [thread-next>] [day] [month] [year] [list]
Message-ID: <CAK-LDbJ+6VnKcsuhRUP13gweetP2p-ioY+ittxDcLqZ5ECxctA@mail.gmail.com>
Date:	Tue, 18 Aug 2015 11:16:31 +0530
From:	Vaishali Thakkar <vthakkar1994@...il.com>
To:	Jacek Anaszewski <j.anaszewski@...sung.com>
Cc:	linux-leds@...r.kernel.org, Bryan Wu <cooloney@...il.com>,
	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] leds: leds-fsg: Use devm_led_classdev_register

On Mon, Aug 17, 2015 at 2:02 PM, Vaishali Thakkar
<vthakkar1994@...il.com> wrote:
>
> On 17 Aug 2015 13:57, "Jacek Anaszewski" <j.anaszewski@...sung.com> wrote:
>>
>> Hi Vaishali,
>>
>> Thanks for the patch. Unfortunately it causes build break.
>> Please fix the issues and resubmit.
>
> Oops! I am really very sorry. By mistake I sent a basic version of patch
> instead of final one. Thanks for the review.
>
> I'll send v2 with the fix of that build error.

Hi Jacek,

Can you please tell me what are those build errors?
After looking at my patch, I can expect that as I forgot to
remove '.remove         = fsg_led_remove' from structure,
it can cause an error. Also, there is one typing mistake in
function name. So, both of these can be a reason for
breaking a build.

Also to be on safe side, I tried to cross compile it for arm
architecture. But to my surprise, it is not compiling properly.
So, it would be good if you can point me to the script you
used for compilation so that I can check it before sending a new
version.

Thank You.

>>
>> On 08/15/2015 12:21 PM, Vaishali Thakkar wrote:
>>>
>>> Use resource-managed function devm_led_classdev_register instead
>>> of led_classdev_register to make the error-path simpler.
>>>
>>> To be compatible with the change, various gotos are replced with
>>> direct returns and unneeded labels are dropped. Also, remove
>>> fsg_led_remove as it is now redundant.
>>>
>>> Signed-off-by: Vaishali Thakkar <vthakkar1994@...il.com>
>>> ---
>>>   drivers/leds/leds-fsg.c | 51
>>> ++++++++++++-------------------------------------
>>>   1 file changed, 12 insertions(+), 39 deletions(-)
>>>
>>> diff --git a/drivers/leds/leds-fsg.c b/drivers/leds/leds-fsg.c
>>> index 2b4dc73..df0e5da 100644
>>> --- a/drivers/leds/leds-fsg.c
>>> +++ b/drivers/leds/leds-fsg.c
>>> @@ -156,60 +156,33 @@ static int fsg_led_probe(struct platform_device
>>> *pdev)
>>>         latch_value = 0xffff;
>>>         *latch_address = latch_value;
>>>
>>> -       ret = led_classdev_register(&pdev->dev, &fsg_wlan_led);
>>> +       ret = devm_led_classdev_register(&pdev->dev, &fsg_wlan_led);
>>>         if (ret < 0)
>>> -               goto failwlan;
>>> +               return ret;
>>>
>>> -       ret = led_classdev_register(&pdev->dev, &fsg_wan_led);
>>> +       ret = devm_led_classdev_register(&pdev->dev, &fsg_wan_led);
>>>         if (ret < 0)
>>> -               goto failwan;
>>> +               return ret;
>>>
>>> -       ret = led_classdev_register(&pdev->dev, &fsg_sata_led);
>>> +       ret = devm_led_classdev_register(&pdev->dev, &fsg_sata_led);
>>>         if (ret < 0)
>>> -               goto failsata;
>>> +               return ret;
>>>
>>> -       ret = led_classdev_register(&pdev->dev, &fsg_usb_led);
>>> +       ret = devm_led_classdev_register(&pdev->dev, &fsg_usb_led);
>>>         if (ret < 0)
>>> -               goto failusb;
>>> +               return ret;
>>>
>>> -       ret = led_classdev_register(&pdev->dev, &fsg_sync_led);
>>> +       ret = devm_classdev_register(&pdev->dev, &fsg_sync_led);
>>>         if (ret < 0)
>>> -               goto failsync;
>>> +               return ret;
>>>
>>> -       ret = led_classdev_register(&pdev->dev, &fsg_ring_led);
>>> +       ret = devm_led_classdev_register(&pdev->dev, &fsg_ring_led);
>>>         if (ret < 0)
>>> -               goto failring;
>>> -
>>> -       return ret;
>>> -
>>> - failring:
>>> -       led_classdev_unregister(&fsg_sync_led);
>>> - failsync:
>>> -       led_classdev_unregister(&fsg_usb_led);
>>> - failusb:
>>> -       led_classdev_unregister(&fsg_sata_led);
>>> - failsata:
>>> -       led_classdev_unregister(&fsg_wan_led);
>>> - failwan:
>>> -       led_classdev_unregister(&fsg_wlan_led);
>>> - failwlan:
>>> +               return ret;
>>>
>>>         return ret;
>>>   }
>>>
>>> -static int fsg_led_remove(struct platform_device *pdev)
>>> -{
>>> -       led_classdev_unregister(&fsg_wlan_led);
>>> -       led_classdev_unregister(&fsg_wan_led);
>>> -       led_classdev_unregister(&fsg_sata_led);
>>> -       led_classdev_unregister(&fsg_usb_led);
>>> -       led_classdev_unregister(&fsg_sync_led);
>>> -       led_classdev_unregister(&fsg_ring_led);
>>> -
>>> -       return 0;
>>> -}
>>> -
>>> -
>>>   static struct platform_driver fsg_led_driver = {
>>>         .probe          = fsg_led_probe,
>>>         .remove         = fsg_led_remove,
>>>
>>
>>
>> --
>> Best Regards,
>> Jacek Anaszewski



-- 
Vaishali
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/