linux-kernel - Re: [PATCH v2 2/5] Documentation: Detail permitted DT properties for the imx6ul

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20150819055434.GF11161@pengutronix.de>
Date:	Wed, 19 Aug 2015 07:54:34 +0200
From:	Markus Pargmann <mpa@...gutronix.de>
To:	Haibo Chen <haibo.chen@...escale.com>
Cc:	robh+dt@...nel.org, pawel.moll@....com, mark.rutland@....com,
	ijc+devicetree@...lion.org.uk, galak@...eaurora.org,
	shawnguo@...nel.org, kernel@...gutronix.de, linux@....linux.org.uk,
	dmitry.torokhov@...il.com, devicetree@...r.kernel.org,
	sbranden@...adcom.com, arnd@...db.de, mchehab@....samsung.com,
	christian.gmeiner@...il.com, scott.liu@....com.tw,
	linux-kernel@...r.kernel.org, hdegoede@...hat.com,
	jonathar@...adcom.com, benjamin.tissoires@...hat.com,
	hans.verkuil@...co.com, hadess@...ess.net,
	linux-input@...r.kernel.org, geert@...ux-m68k.org,
	sebastien.szymanski@...adeus.com, mamlinav@...il.com,
	linux-arm-kernel@...ts.infradead.org
Subject: Re: [PATCH v2 2/5] Documentation: Detail permitted DT properties for
 the imx6ul_tsc

Hi,

On Tue, Jul 28, 2015 at 05:58:38PM +0800, Haibo Chen wrote:
> Here we apply required documentation for the imx6ul touch screen
> controller driver which describe available properties and how to
> use them.
> 
> Signed-off-by: Haibo Chen <haibo.chen@...escale.com>
> ---
>  .../bindings/input/touchscreen/imx6ul_tsc.txt      | 36 ++++++++++++++++++++++
>  1 file changed, 36 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/input/touchscreen/imx6ul_tsc.txt
> 
> diff --git a/Documentation/devicetree/bindings/input/touchscreen/imx6ul_tsc.txt b/Documentation/devicetree/bindings/input/touchscreen/imx6ul_tsc.txt
> new file mode 100644
> index 0000000..ac41c32
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/input/touchscreen/imx6ul_tsc.txt
> @@ -0,0 +1,36 @@
> +* Freescale i.MX6UL Touch Controller
> +
> +Required properties:
> +- compatible: must be "fsl,imx6ul-tsc".
> +- reg: this touch controller address and the ADC2 address.

This suggests that this driver is using a unit ADC2. Which also means
that there are more than one ADC which are probably identical?

Shouldn't these ADCs be properly described by their own device nodes
instead of these two register ranges, two interrupts and two clocks?

Is 'ADC2' usable without tsc? Then ADC1/ADC2 should perhaps get a proper
IIO driver.

Unfortunately I don't have the reference manual to have a look how this
all works.

Best regards,

Markus

> +- interrupts: the interrupt of this touch controller and ADC2.
> +- clocks: the root clock of touch controller and ADC2.
> +- clock-names; must be "tsc" and "adc".
> +- xnur-gpio: the X- gpio this controller connect to.
> +  This xnur-gpio returns to high once the finger leave the touch screen (The
> +  last touch event the touch controller capture).
> +
> +Optional properties:
> +- measure-delay-time: the value of measure delay time.
> +  Before X-axis or Y-axis measurement, the screen need some time before
> +  even potential distribution ready.
> +  This value depends on the touch screen.
> +- pre-charge-time: the touch screen need some time to precharge.
> +  This value depends on the touch screen.
> +
> +Example:
> +	tsc: tsc@...40000 {
> +		compatible = "fsl,imx6ul-tsc";
> +		reg = <0x02040000 0x4000>, <0x0219c000 0x4000>;
> +		interrupts = <GIC_SPI 3 IRQ_TYPE_LEVEL_HIGH>,
> +			     <GIC_SPI 101 IRQ_TYPE_LEVEL_HIGH>;
> +		clocks = <&clks IMX6UL_CLK_IPG>,
> +			 <&clks IMX6UL_CLK_ADC2>;
> +		clock-names = "tsc", "adc";
> +		pinctrl-names = "default";
> +		pinctrl-0 = <&pinctrl_tsc>;
> +		xnur-gpio = <&gpio1 3 GPIO_ACTIVE_HIGH>;
> +		measure-delay-time = <0xfff>;
> +		pre-charge-time = <0xffff>;
> +		status = "okay";
> +	};
> -- 
> 1.9.1
> 
> 
> 

-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

Download attachment "signature.asc" of type "application/pgp-signature" (820 bytes)