| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <COL130-W42419C917737D318BC8E6DB9660@phx.gbl>
Date: Thu, 20 Aug 2015 09:26:28 +0800
From: gchen gchen <xili_gchen_5257@...mail.com>
To: Andrew Morton <akpm@...ux-foundation.org>
CC: kernel mailing list <linux-kernel@...r.kernel.org>,
"Kirill A. Shutemov" <kirill.shutemov@...ux.intel.com>,
"riel@...hat.com" <riel@...hat.com>, Michal Hocko <mhocko@...e.cz>,
"sasha.levin@...cle.com" <sasha.levin@...cle.com>,
Linux Memory <linux-mm@...ck.org>
Subject: Re: [PATCH] mm: mmap: Simplify the failure return working flow
<br>On Tue, 18 Aug 2015 15:57:08 -0700 akpm@...ux-foundation.org wrote:<br>><br>> On Wed, 19 Aug 2015 06:27:58 +0800 Chen Gang<br>> <xili_gchen_5257@...mail.com> wrote:<br>><br>>> From: Chen Gang <xili_gchen_5257@...mail.com><br>><br>> As sent, this patch is From:you@...mail and Signed-off-by:you@...il.<br>><br>> This is peculiar. I'm assuming that it should have been From:you@...il and<br>> I have made that change to my copy of the patch.<br>><br>> You can do this yourself by putting an explicit From: line at the start<br>> of the changelog.<br>><br><br>Yes, it is really peculiar, the reason is gmail is not stable in China.<br>I have to send mail in my hotmail address.<br><br>But I still want to use my gmail as Signed-off-by, since I have already<br>used it, and also its name is a little formal than my hotmail.<br><br>Welcome any ideas, suggestions and completions for it (e.g. if it is<br>necessary to let send mail and Signed-off-by mail be the same, I shall<br>try).<br><br>[...]<br><br>> So,<br>><br>> --- a/mm/mmap.c~mm-mmap-simplify-the-failure-return-working-flow-fix<br>> +++ a/mm/mmap.c<br>> @@ -2952,7 +2952,7 @@ struct vm_area_struct *copy_vma(struct v<br>> } else {<br>> new_vma = kmem_cache_alloc(vm_area_cachep, GFP_KERNEL);<br>> if (!new_vma)<br>> - return NULL;<br>> + goto out;<br>> *new_vma = *vma;<br>> new_vma->vm_start = addr;<br>> new_vma->vm_end = addr + len;<br>> @@ -2971,10 +2971,11 @@ struct vm_area_struct *copy_vma(struct v<br>> }<br>> return new_vma;<br>><br>> - out_free_mempol:<br>> +out_free_mempol:<br>> mpol_put(vma_policy(new_vma));<br>> - out_free_vma:<br>> +out_free_vma:<br>> kmem_cache_free(vm_area_cachep, new_vma);<br>> +out:<br>> return NULL;<br>> }<br>><br><br>It is OK to me, thanks.<br><br>During these days (2-4 months), I shall try to make some patches for<br>Linux mm:<br><br> - I am learning Linux kernel mmu, so I can re-use part of code to user<br> mode (add softmmu to qemu linux user in my working time). Then I can<br> try some mm patches when I am reading related code.<br><br> - At present, cross-building various archs with allmodconfig looks OK<br> (have no many issues), so for me, I can stop and start another parts<br> (e.g. mmu, loongson machine of mips arch, ...).<br><br>Welcome any ideas, suggestions and completions for it:<br><br> - Assume I am not quite familiar with mmu -- in honest, I feel I am<br> really not.<br><br> - Is it possible to build the related 'softmmu' as a module which can<br> be used by both kernel mode and user mode (if really it is, I shall<br> try to perform it -- I can do it in my working time).<br><br> - ...<br><br>Thanks.<br>--<br>Chen Gang<br><br>Open, share, and attitude like air, water, and life which God blessed<br>
Powered by blists - more mailing lists