| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <1440034811.13406.9.camel@ellerman.id.au> Date: Thu, 20 Aug 2015 11:40:11 +1000 From: Michael Ellerman <mpe@...erman.id.au> To: Laurent Dufour <ldufour@...ux.vnet.ibm.com> Cc: linuxppc-dev@...ts.ozlabs.org, Greg Kroah-Hartman <gregkh@...uxfoundation.org>, Jiri Slaby <jslaby@...e.cz>, linux-kernel@...r.kernel.org Subject: Re: [PATCH] powerpc/hvsi: Fix endianness issues in the HVSI driver On Wed, 2015-08-19 at 23:53 +0200, Laurent Dufour wrote: > On 04/08/2015 02:51, Michael Ellerman wrote: > > On Fri, 2015-07-31 at 11:29 +0200, Laurent Dufour wrote: > >> This patch fixes several endianness issues detected when running the HVSI > >> driver in little endian mode. > >> > >> These issues are raised in little endian mode because the data exchanged in > >> memory between the kernel and the hypervisor has to be in big endian > >> format. > > > > Can you include the sparse output before and after? > > Hi Michael, > > Here is the output message displayed on the console when the bug occurred: > > [ 0.000517] irq: (null) didn't like hwirq-0x1000a00 to VIRQ16 mapping (rc=-22) > [ 0.000578] hvsi_console_init: couldn't create irq mapping for 0x1000a00 > > With the patch is applied, the hvsi driver is initializing correctly and > no message is displayed, except the one saying the number of device the > hvsi driver has configured. For instance: > [ 1.535783] HVSI: registered 1 devices OK that's also good. I was talking about the output from sparse endian checking, as the driver seems to already be endian annotated. ie, before: $ make C=2 CF=-D__CHECK_ENDIAN__ ... drivers/tty/hvc/hvsi.c:245:36: warning: restricted __be32 degrades to integer drivers/tty/hvc/hvsi.c:243:23: warning: restricted __be16 degrades to integer drivers/tty/hvc/hvsi.c:243:23: warning: restricted __be16 degrades to integer drivers/tty/hvc/hvsi.c:277:36: warning: restricted __be32 degrades to integer drivers/tty/hvc/hvsi.c:279:36: warning: restricted __be32 degrades to integer drivers/tty/hvc/hvsi.c:298:26: warning: incorrect type in assignment (different base types) drivers/tty/hvc/hvsi.c:298:26: expected restricted __be16 [assigned] [usertype] seqno drivers/tty/hvc/hvsi.c:298:26: got int drivers/tty/hvc/hvsi.c:299:21: warning: incorrect type in assignment (different base types) drivers/tty/hvc/hvsi.c:299:21: expected restricted __be16 [assigned] [usertype] verb drivers/tty/hvc/hvsi.c:299:21: got int drivers/tty/hvc/hvsi.c:301:28: warning: incorrect type in assignment (different base types) drivers/tty/hvc/hvsi.c:301:28: expected restricted __be16 [assigned] [usertype] query_seqno drivers/tty/hvc/hvsi.c:301:28: got int drivers/tty/hvc/hvsi.c:322:60: warning: incorrect type in argument 2 (different base types) drivers/tty/hvc/hvsi.c:322:60: expected unsigned short [unsigned] [usertype] query_seqno drivers/tty/hvc/hvsi.c:322:60: got restricted __be16 [usertype] seqno drivers/tty/hvc/hvsi.c:558:26: warning: incorrect type in assignment (different base types) drivers/tty/hvc/hvsi.c:558:26: expected restricted __be16 [assigned] [usertype] seqno drivers/tty/hvc/hvsi.c:558:26: got int drivers/tty/hvc/hvsi.c:559:21: warning: incorrect type in assignment (different base types) drivers/tty/hvc/hvsi.c:559:21: expected restricted __be16 [assigned] [usertype] verb drivers/tty/hvc/hvsi.c:559:21: got unsigned short [unsigned] [usertype] verb drivers/tty/hvc/hvsi.c:600:26: warning: incorrect type in assignment (different base types) drivers/tty/hvc/hvsi.c:600:26: expected restricted __be16 [assigned] [usertype] seqno drivers/tty/hvc/hvsi.c:600:26: got int drivers/tty/hvc/hvsi.c:602:21: warning: incorrect type in assignment (different base types) drivers/tty/hvc/hvsi.c:602:21: expected restricted __be16 [assigned] [usertype] verb drivers/tty/hvc/hvsi.c:602:21: got int drivers/tty/hvc/hvsi.c:603:21: warning: incorrect type in assignment (different base types) drivers/tty/hvc/hvsi.c:603:21: expected restricted __be32 [assigned] [usertype] mask drivers/tty/hvc/hvsi.c:603:21: got int drivers/tty/hvc/hvsi.c:606:29: warning: incorrect type in assignment (different base types) drivers/tty/hvc/hvsi.c:606:29: expected restricted __be32 [assigned] [usertype] word drivers/tty/hvc/hvsi.c:606:29: got int drivers/tty/hvc/hvsi.c:683:26: warning: incorrect type in assignment (different base types) drivers/tty/hvc/hvsi.c:683:26: expected restricted __be16 [assigned] [usertype] seqno drivers/tty/hvc/hvsi.c:683:26: got int drivers/tty/hvc/hvsi.c:700:26: warning: incorrect type in assignment (different base types) drivers/tty/hvc/hvsi.c:700:26: expected restricted __be16 [assigned] [usertype] seqno drivers/tty/hvc/hvsi.c:700:26: got int drivers/tty/hvc/hvsi.c:702:21: warning: incorrect type in assignment (different base types) drivers/tty/hvc/hvsi.c:702:21: expected restricted __be16 [assigned] [usertype] verb drivers/tty/hvc/hvsi.c:702:21: got int ... And with your patch applied there are no warnings from hvsi.c! So it seems you fixed all the issues, or at least all the issues we can detect with sparse. So I'll merge this as-is with an updated changelog. cheers -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists