linux-kernel - Re: [PATCH v2 7/8] scsi: ufs-qcom: add debug prints for test bus

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAC5umyj8i2N3Xzdqye2mQY3WF5MbpEm61LjO0HYMk-mvbUnL7A@mail.gmail.com>
Date:	Sat, 22 Aug 2015 11:56:14 +0900
From:	Akinobu Mita <akinobu.mita@...il.com>
To:	Yaniv Gardi <ygardi@...eaurora.org>
Cc:	Rob Herring <robherring2@...il.com>,
	Jej B <james.bottomley@...senpartnership.com>,
	Paul Bolle <pebolle@...cali.nl>,
	Christoph Hellwig <hch@...radead.org>,
	LKML <linux-kernel@...r.kernel.org>,
	"linux-scsi@...r.kernel.org" <linux-scsi@...r.kernel.org>,
	linux-arm-msm@...r.kernel.org, Santosh Y <santoshsy@...il.com>,
	linux-scsi-owner@...r.kernel.org,
	Subhash Jadavani <subhashj@...eaurora.org>,
	Gilad Broner <gbroner@...eaurora.org>,
	Dolev Raviv <draviv@...eaurora.org>,
	Vinayak Holikatti <vinholikatti@...il.com>,
	"James E.J. Bottomley" <jbottomley@...n.com>
Subject: Re: [PATCH v2 7/8] scsi: ufs-qcom: add debug prints for test bus

2015-08-22 7:23 GMT+09:00  <ygardi@...eaurora.org>:
>> 2015-08-20 22:59 GMT+09:00 Yaniv Gardi <ygardi@...eaurora.org>:
>>> @@ -30,6 +48,14 @@ static void ufs_qcom_get_speed_mode(struct
>>> ufs_pa_layer_attr *p, char *result);
>>>  static int ufs_qcom_get_bus_vote(struct ufs_qcom_host *host,
>>>                 const char *speed_mode);
>>>  static int ufs_qcom_set_bus_vote(struct ufs_qcom_host *host, int vote);
>>> +static void ufs_qcom_get_default_testbus_cfg(struct ufs_qcom_host
>>> *host);
>>> +static void ufs_qcom_dump_regs(struct ufs_hba *hba, int offset, int
>>> len,
>>> +               char *prefix)
>>> +{
>>> +       print_hex_dump(KERN_ERR, prefix,
>>> +                       len > 4 ? DUMP_PREFIX_OFFSET : DUMP_PREFIX_NONE,
>>> +                       16, 4, hba->mmio_base + offset, len * 4, false);
>>> +}
>>
>> This causes a sparse warning as __iomem pointer is passed to
>> print_hex_dump().
>
> indeed.
> any suggestions how it can be fixed ? I guess I shall try casting.

I think introducing generic print_hex_dump_io() library function
is useful for this and other drivers want to use it.  But for now we can just
create simple local dump function which readl() and print for each register.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/