linux-kernel - Re: [PATCH v2 7/8] scsi: ufs-qcom: add debug prints for test bus

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAC5umyhX0kD=v+3fsU+BYSbsfde6jAxuG4EgvvYTQc7hF8mW6g@mail.gmail.com>
Date:	Sat, 22 Aug 2015 12:07:52 +0900
From:	Akinobu Mita <akinobu.mita@...il.com>
To:	Yaniv Gardi <ygardi@...eaurora.org>
Cc:	Rob Herring <robherring2@...il.com>,
	Jej B <James.Bottomley@...senpartnership.com>,
	Paul Bolle <pebolle@...cali.nl>,
	Christoph Hellwig <hch@...radead.org>,
	LKML <linux-kernel@...r.kernel.org>,
	"linux-scsi@...r.kernel.org" <linux-scsi@...r.kernel.org>,
	linux-arm-msm@...r.kernel.org, Santosh Y <santoshsy@...il.com>,
	linux-scsi-owner@...r.kernel.org,
	Subhash Jadavani <subhashj@...eaurora.org>,
	Gilad Broner <gbroner@...eaurora.org>,
	Dolev Raviv <draviv@...eaurora.org>,
	Vinayak Holikatti <vinholikatti@...il.com>,
	"James E.J. Bottomley" <JBottomley@...n.com>
Subject: Re: [PATCH v2 7/8] scsi: ufs-qcom: add debug prints for test bus

2015-08-20 22:59 GMT+09:00 Yaniv Gardi <ygardi@...eaurora.org>:

> +static bool ufs_qcom_testbus_cfg_is_ok(struct ufs_qcom_host *host)
> +{
> +       if (host->testbus.select_major >= TSTBUS_MAX) {
> +               dev_err(host->hba->dev,
> +                       "%s: UFS_CFG1[TEST_BUS_SEL} may not equal 0x%05X\n",
> +                       __func__, host->testbus.select_major);
> +               return false;
> +       }
> +
> +       /*
> +        * Not performing check for each individual select_major
> +        * mappings of select_minor, since there is no harm in
> +        * configuring a non-existent select_minor
> +        */
> +       if (host->testbus.select_major > 0x1F) {

select_minor should be checked instead of select_major here?

> +               dev_err(host->hba->dev,
> +                       "%s: 0x%05X is not a legal testbus option\n",
> +                       __func__, host->testbus.select_minor);
> +               return false;
> +       }
> +
> +       return true;
> +}
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/