[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20150822092429.GB18233@gmail.com>
Date: Sat, 22 Aug 2015 11:24:29 +0200
From: Ingo Molnar <mingo@...nel.org>
To: "Jonathan (Zhixiong) Zhang" <zjzhang@...eaurora.org>
Cc: Will Deacon <will.deacon@....com>,
Thomas Gleixner <tglx@...utronix.de>,
"H . Peter Anvin" <hpa@...or.com>,
"linux-kernel @ vger . kernel . org" <linux-kernel@...r.kernel.org>,
"linux-efi @ vger . kernel . org" <linux-efi@...r.kernel.org>,
Matt Fleming <matt.fleming@...el.com>,
Borislav Petkov <bp@...e.de>,
Ard Biesheuvel <ard.biesheuvel@...aro.org>,
Catalin Marinas <Catalin.Marinas@....com>,
Matt Fleming <matt@...eblueprint.co.uk>
Subject: Re: [PATCH 2/2] acpi, apei: use appropriate pgprot_t to map GHES
memory
* Jonathan (Zhixiong) Zhang <zjzhang@...eaurora.org> wrote:
> From: "Jonathan (Zhixiong) Zhang" <zjzhang@...eaurora.org>
>
> With ACPI APEI firmware first handling, generic hardware error
> record is updated by firmware in GHES memory region. On an arm64
> platform, firmware updates GHES memory region with uncached
> access attribute, and then Linux reads stale data from cache.
This paragraph *still* doesn't parse for me. It's not any English
I can recognize: what is a 'With ACPI APEI firmware first handling'?
> With current code, GHES memory region is mapped with PAGE_KERNEL
> based on the assumption that cache coherency of GHES memory region
> is maintained by firmware on all platforms. This assumption is
> not true for above mentioned arm64 platform.
>
> Instead GHES memory region should be mapped with page protection type
> according to what is returned from arch_apei_get_mem_attribute().
... plus what this changelog still doesn't mention is the most important part of
any bug fix description: how does the user notice this in practice and why does he
care?
Thanks,
Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists