linux-kernel - Re: [PATCH] SCSI: DTC: Adding KERN

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <alpine.LNX.2.00.1508241518160.19365@nippy.intranet>
Date:	Tue, 25 Aug 2015 11:53:53 +1000 (AEST)
From:	Finn Thain <fthain@...egraphics.com.au>
To:	Rudhresh Kumar J <rudhresh.jk@...il.com>
cc:	schmitzmic@...il.com, JBottomley@...n.com,
	linux-scsi@...r.kernel.org, linux-kernel@...r.kernel.org,
	Rudhresh Kumar J <rudhreshj@...c.in>
Subject: Re: [PATCH] SCSI: DTC: Adding KERN_ facility level


On Tue, 30 Jun 2015, Rudhresh Kumar J wrote:

> Fixed coding style issue by adding KERN_ facility level to some of
> the printk functions.
> 
> Signed-off-by: Rudhresh Kumar J <rudhresh.jk@...il.com>
> ---
>  drivers/scsi/dtc.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/scsi/dtc.c b/drivers/scsi/dtc.c
> index 4c74c7b..a3a2a71 100644
> --- a/drivers/scsi/dtc.c
> +++ b/drivers/scsi/dtc.c
> @@ -156,7 +156,7 @@ static int __init dtc_setup(char *str)
>  
>  	get_options(str, ARRAY_SIZE(ints), ints);
>  	if (ints[0] != 2)
> -		printk("dtc_setup: usage dtc=address,irq\n");
> +		printk(KERN_DEBUG "dtc_setup: usage dtc=address,irq\n");

No, that is an error message that the user needs to see.

>  	else if (commandline_current < NO_OVERRIDES) {
>  		overrides[commandline_current].address = ints[1];
>  		overrides[commandline_current].irq = ints[2];
> @@ -272,7 +272,7 @@ found:
>  		instance->irq = NO_IRQ;
>  #endif
>  #if defined(DTCDEBUG) && (DTCDEBUG & DTCDEBUG_INIT)
> -		printk("scsi%d : irq = %d\n", instance->host_no, instance->irq);
> +		printk(KERN_DEBUG "scsi%d : irq = %d\n", instance->host_no, instance->irq);
>  #endif
>  
>  		++current_override;
> 

I have a better patch for this, which makes use of the dprintk macro to 
replace {DTC,P,T}DEBUG_INIT with NDEBUG_INIT. Thanks anyway.

-- 
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/